Re: [PATCH 4/5] arm: mvebu: Espressobin: Define console env

2020-08-27 Thread Andre Heider
On 27/08/2020 12:29, Pali Rohár wrote: On Thursday 27 August 2020 06:51:57 Andre Heider wrote: On the other hand, check "git grep 'console='". So why not just add the earlycon to bootargs directly so it works everywhere? The only useful thing about CONFIG_DEFAULT_CONSOLE and ${console} env is

Re: [PATCH 4/5] arm: mvebu: Espressobin: Define console env

2020-08-27 Thread Pali Rohár
On Thursday 27 August 2020 06:51:57 Andre Heider wrote: > On the other hand, check "git grep 'console='". So why not just add the > earlycon to bootargs directly so it works everywhere? The only useful thing about CONFIG_DEFAULT_CONSOLE and ${console} env is to propagate earlycon argument to kerne

Re: [PATCH 4/5] arm: mvebu: Espressobin: Define console env

2020-08-26 Thread Andre Heider
On 26/08/2020 17:10, Pali Rohár wrote: On Wednesday 26 August 2020 16:43:10 Andre Heider wrote: Debian's boot.scr set "bootargs" to "... console=${console}". So we end up with with kernel args "console=console=..." :) So then also other U-Boot boards are broken in Debian... fyi: I opened a

Re: [PATCH 4/5] arm: mvebu: Espressobin: Define console env

2020-08-26 Thread Andre Heider
On 26/08/2020 17:10, Pali Rohár wrote: On Wednesday 26 August 2020 16:43:10 Andre Heider wrote: On 26/08/2020 16:10, Pali Rohár wrote: On Wednesday 26 August 2020 16:00:05 Andre Heider wrote: On 26/08/2020 15:31, Pali Rohár wrote: On Wednesday 26 August 2020 15:22:26 Andre Heider wrote: Hi,

Re: [PATCH 4/5] arm: mvebu: Espressobin: Define console env

2020-08-26 Thread Andre Heider
On 26/08/2020 17:10, Pali Rohár wrote: On Wednesday 26 August 2020 16:43:10 Andre Heider wrote: On 26/08/2020 16:10, Pali Rohár wrote: On Wednesday 26 August 2020 16:00:05 Andre Heider wrote: On 26/08/2020 15:31, Pali Rohár wrote: On Wednesday 26 August 2020 15:22:26 Andre Heider wrote: Hi,

Re: [PATCH 4/5] arm: mvebu: Espressobin: Define console env

2020-08-26 Thread Pali Rohár
On Wednesday 26 August 2020 16:43:10 Andre Heider wrote: > On 26/08/2020 16:10, Pali Rohár wrote: > > On Wednesday 26 August 2020 16:00:05 Andre Heider wrote: > > > On 26/08/2020 15:31, Pali Rohár wrote: > > > > On Wednesday 26 August 2020 15:22:26 Andre Heider wrote: > > > > > Hi, > > > > > > > >

Re: [PATCH 4/5] arm: mvebu: Espressobin: Define console env

2020-08-26 Thread Andre Heider
On 26/08/2020 16:10, Pali Rohár wrote: On Wednesday 26 August 2020 16:00:05 Andre Heider wrote: On 26/08/2020 15:31, Pali Rohár wrote: On Wednesday 26 August 2020 15:22:26 Andre Heider wrote: Hi, On 24/08/2020 16:25, Pali Rohár wrote: Some distribution bootscripts append console env into boo

Re: [PATCH 4/5] arm: mvebu: Espressobin: Define console env

2020-08-26 Thread Pali Rohár
On Wednesday 26 August 2020 16:00:05 Andre Heider wrote: > On 26/08/2020 15:31, Pali Rohár wrote: > > On Wednesday 26 August 2020 15:22:26 Andre Heider wrote: > > > Hi, > > > > > > On 24/08/2020 16:25, Pali Rohár wrote: > > > > Some distribution bootscripts append console env into boot cmdline. >

Re: [PATCH 4/5] arm: mvebu: Espressobin: Define console env

2020-08-26 Thread Andre Heider
On 26/08/2020 15:31, Pali Rohár wrote: On Wednesday 26 August 2020 15:22:26 Andre Heider wrote: Hi, On 24/08/2020 16:25, Pali Rohár wrote: Some distribution bootscripts append console env into boot cmdline. So define console env correctly to have early console access. Signed-off-by: Pali Rohá

Re: [PATCH 4/5] arm: mvebu: Espressobin: Define console env

2020-08-26 Thread Pali Rohár
On Wednesday 26 August 2020 15:22:26 Andre Heider wrote: > Hi, > > On 24/08/2020 16:25, Pali Rohár wrote: > > Some distribution bootscripts append console env into boot cmdline. > > So define console env correctly to have early console access. > > > > Signed-off-by: Pali Rohár > > --- > > incl

Re: [PATCH 4/5] arm: mvebu: Espressobin: Define console env

2020-08-26 Thread Andre Heider
Hi, On 24/08/2020 16:25, Pali Rohár wrote: Some distribution bootscripts append console env into boot cmdline. So define console env correctly to have early console access. Signed-off-by: Pali Rohár --- include/configs/mvebu_armada-37xx.h | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [PATCH 4/5] arm: mvebu: Espressobin: Define console env

2020-08-25 Thread Stefan Roese
On 24.08.20 16:25, Pali Rohár wrote: Some distribution bootscripts append console env into boot cmdline. So define console env correctly to have early console access. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan

[PATCH 4/5] arm: mvebu: Espressobin: Define console env

2020-08-24 Thread Pali Rohár
Some distribution bootscripts append console env into boot cmdline. So define console env correctly to have early console access. Signed-off-by: Pali Rohár --- include/configs/mvebu_armada-37xx.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/configs/mvebu_armada-37xx.h b/include