Re: [PATCH 4/4] x86: apl: Add hex offsets for registers in FSP-S

2020-05-26 Thread Bin Meng
Hi Simon, On Tue, May 26, 2020 at 4:16 AM Simon Glass wrote: > > When comparing hex dumps it is useful to see the offsets of the registers. > Add them in where they correspond to a multiple of 16. > > Possibly it would be useful to have a a command to output the FSP values > in human-readable for

[PATCH 4/4] x86: apl: Add hex offsets for registers in FSP-S

2020-05-25 Thread Simon Glass
When comparing hex dumps it is useful to see the offsets of the registers. Add them in where they correspond to a multiple of 16. Possibly it would be useful to have a a command to output the FSP values in human-readable form, making use of the fsp_bindings implementation. Signed-off-by: Simon Gl