Re: [PATCH 4/4] spi: Add Microchip PolarFire SoC QSPI driver

Hi Conor, > On Wed, 2022-10-19 at 17:20 +0100, Conor Dooley wrote: > > On Wed, Oct 19, 2022 at 08:23:22PM +0530, Padmarao Begari wrote: > > Add QSPI driver code for the Microchip PolarFire SoC. > > This driver supports the qspi standard, dual and quad > > mode interfaces. > > > > Signed-off-by:

Re: [PATCH 4/4] spi: Add Microchip PolarFire SoC QSPI driver

Hi Conor, > On Wed, 2022-10-19 at 16:47 +0100, Conor Dooley wrote: > > On Wed, Oct 19, 2022 at 03:16:01PM +, tudor.amba...@microchip.com > wrote: > > Hi! > > > > On 10/19/22 17:53, Padmarao Begari wrote: > > > drivers/spi/microchip_qspi.c | 504 > > > +++ > >

Re: [PATCH 4/4] spi: Add Microchip PolarFire SoC QSPI driver

On Wed, Oct 19, 2022 at 08:23:22PM +0530, Padmarao Begari wrote: > Add QSPI driver code for the Microchip PolarFire SoC. > This driver supports the qspi standard, dual and quad > mode interfaces. > > Signed-off-by: Padmarao Begari > Signed-off-by: Naga Sureshkumar Relli > --- > drivers/spi/Kcon

Re: [PATCH 4/4] spi: Add Microchip PolarFire SoC QSPI driver

On Wed, Oct 19, 2022 at 03:16:01PM +, tudor.amba...@microchip.com wrote: > Hi! > > On 10/19/22 17:53, Padmarao Begari wrote: > > drivers/spi/microchip_qspi.c | 504 +++ > > The name is too generic, there are multiple QSPI IPs inside mchp. > I would suggest to c

Re: [PATCH 4/4] spi: Add Microchip PolarFire SoC QSPI driver

Hi! On 10/19/22 17:53, Padmarao Begari wrote: > drivers/spi/microchip_qspi.c | 504 +++ The name is too generic, there are multiple QSPI IPs inside mchp. I would suggest to create an mchp directory and rename your c file to maybe something like mpfs-qspi? -- Che

[PATCH 4/4] spi: Add Microchip PolarFire SoC QSPI driver

Add QSPI driver code for the Microchip PolarFire SoC. This driver supports the qspi standard, dual and quad mode interfaces. Signed-off-by: Padmarao Begari Signed-off-by: Naga Sureshkumar Relli --- drivers/spi/Kconfig | 6 + drivers/spi/Makefile | 1 + drivers/spi/microchip