Re: [PATCH 3/5] usb: dwc3-generic: Add dependency on SIMPLE_BUS

2023-01-31 Thread Marek Vasut
On 1/31/23 01:27, Kunihiko Hayashi wrote: Hi Marek, Hello Hayashi-san, On 2023/01/31 7:50, Marek Vasut wrote: On 1/30/23 06:52, Kunihiko Hayashi wrote: Hi Marek, Hello Hayashi-san, Sorry for late reply. I was stuck in some pitfalls. No worries, the MW closed today, but rc2 should be s

Re: [PATCH 3/5] usb: dwc3-generic: Add dependency on SIMPLE_BUS

2023-01-30 Thread Kunihiko Hayashi
Hi Marek, On 2023/01/31 7:50, Marek Vasut wrote: On 1/30/23 06:52, Kunihiko Hayashi wrote: Hi Marek, Hello Hayashi-san, Sorry for late reply. I was stuck in some pitfalls. No worries, the MW closed today, but rc2 should be still OK to land these patches. Thank you for caring. [...]

Re: [PATCH 3/5] usb: dwc3-generic: Add dependency on SIMPLE_BUS

2023-01-30 Thread Marek Vasut
On 1/30/23 06:52, Kunihiko Hayashi wrote: Hi Marek, Hello Hayashi-san, Sorry for late reply. I was stuck in some pitfalls. No worries, the MW closed today, but rc2 should be still OK to land these patches. [...] I've successfully enabled the regular usb node using your suggested patch

Re: [PATCH 3/5] usb: dwc3-generic: Add dependency on SIMPLE_BUS

2023-01-29 Thread Kunihiko Hayashi
Hi Marek, Sorry for late reply. I was stuck in some pitfalls. On 2023/01/25 22:03, Marek Vasut wrote: On 1/25/23 09:40, Kunihiko Hayashi wrote: Hi Marek, Hello Hayashi-san, [...] The idea is that the dwc3-generic.c (or dwc3-uniphier.c , placement does not really matter) binds to "socionex

Re: [PATCH 3/5] usb: dwc3-generic: Add dependency on SIMPLE_BUS

2023-01-25 Thread Marek Vasut
On 1/25/23 09:40, Kunihiko Hayashi wrote: Hi Marek, Hello Hayashi-san, [...] The idea is that the dwc3-generic.c (or dwc3-uniphier.c , placement does not really matter) binds to "socionext,uniphier-pxs3-dwc3-glue" compatible first. Then, the dwc3_glue_ops is extended with a new callback glu

Re: [PATCH 3/5] usb: dwc3-generic: Add dependency on SIMPLE_BUS

2023-01-25 Thread Kunihiko Hayashi
Hi Marek, On 2023/01/25 10:38, Marek Vasut wrote: On 1/24/23 03:53, Kunihiko Hayashi wrote: Hi Marek, Hello Hayashi-san, On 2023/01/24 0:49, Marek Vasut wrote: On 1/23/23 06:01, Kunihiko Hayashi wrote: Hi Marek, Hello Hayashi-san, [...] On the other hand, the PXS2 controller for exam

Re: [PATCH 3/5] usb: dwc3-generic: Add dependency on SIMPLE_BUS

2023-01-24 Thread Marek Vasut
On 1/24/23 03:53, Kunihiko Hayashi wrote: Hi Marek, Hello Hayashi-san, On 2023/01/24 0:49, Marek Vasut wrote: On 1/23/23 06:01, Kunihiko Hayashi wrote: Hi Marek, Hello Hayashi-san, [...] On the other hand, the PXS2 controller for example is not a bus: arch/arm/dts/uniphier-pxs2.dtsi:

Re: [PATCH 3/5] usb: dwc3-generic: Add dependency on SIMPLE_BUS

2023-01-23 Thread Kunihiko Hayashi
Hi Marek, On 2023/01/24 0:49, Marek Vasut wrote: On 1/23/23 06:01, Kunihiko Hayashi wrote: Hi Marek, Hello Hayashi-san, [...] On the other hand, the PXS2 controller for example is not a bus: arch/arm/dts/uniphier-pxs2.dtsi: 596 _usb0: usb@65a0 { 597 compatible = "socionext,uniphie

Re: [PATCH 3/5] usb: dwc3-generic: Add dependency on SIMPLE_BUS

2023-01-23 Thread Marek Vasut
On 1/23/23 06:01, Kunihiko Hayashi wrote: Hi Marek, Hello Hayashi-san, [...] On the other hand, the PXS2 controller for example is not a bus: arch/arm/dts/uniphier-pxs2.dtsi: 596 _usb0: usb@65a0 { 597 compatible = "socionext,uniphier-dwc3", "snps,dwc3"; 598 status = "disabled";

Re: [PATCH 3/5] usb: dwc3-generic: Add dependency on SIMPLE_BUS

2023-01-22 Thread Kunihiko Hayashi
Hi Marek, On 2023/01/23 12:37, Marek Vasut wrote: On 1/23/23 04:08, Kunihiko Hayashi wrote: Hello Hayashi-san, diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig index f010291d02..dadaa083e7 100644 --- a/drivers/usb/dwc3/Kconfig +++ b/drivers/usb/dwc3/Kconfig @@ -25,14 +25,14 @@

Re: [PATCH 3/5] usb: dwc3-generic: Add dependency on SIMPLE_BUS

2023-01-22 Thread Marek Vasut
On 1/23/23 04:08, Kunihiko Hayashi wrote: Hello Hayashi-san, diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig index f010291d02..dadaa083e7 100644 --- a/drivers/usb/dwc3/Kconfig +++ b/drivers/usb/dwc3/Kconfig @@ -25,14 +25,14 @@ config USB_DWC3_OMAP    config USB_DWC3_GENERIC    

Re: [PATCH 3/5] usb: dwc3-generic: Add dependency on SIMPLE_BUS

2023-01-22 Thread Kunihiko Hayashi
Hi Marek, Thank you for reviewing. On 2023/01/23 10:42, Marek Vasut wrote: On 1/23/23 01:47, Kunihiko Hayashi wrote: The glue driver doesn't do or offer actively anything, SIMPLE_BUS is more preferable to represent the driver. Signed-off-by: Kunihiko Hayashi --- drivers/usb/dwc3/Kconfig |

Re: [PATCH 3/5] usb: dwc3-generic: Add dependency on SIMPLE_BUS

2023-01-22 Thread Marek Vasut
On 1/23/23 01:47, Kunihiko Hayashi wrote: The glue driver doesn't do or offer actively anything, SIMPLE_BUS is more preferable to represent the driver. Signed-off-by: Kunihiko Hayashi --- drivers/usb/dwc3/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH 3/5] usb: dwc3-generic: Add dependency on SIMPLE_BUS

2023-01-22 Thread Kunihiko Hayashi
The glue driver doesn't do or offer actively anything, SIMPLE_BUS is more preferable to represent the driver. Signed-off-by: Kunihiko Hayashi --- drivers/usb/dwc3/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig i