Re: [PATCH 3/3] patman: fix project-defaults not propagating into parsers

2020-12-22 Thread Simon Glass
Hi Philipp, On Wed, 25 Nov 2020 at 12:41, Philipp Tomsich wrote: > > Simon, > > On Wed, 25 Nov 2020 at 16:30, Simon Glass wrote: > > Here is a pointer to the docs I saw: > > > > https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.set_defaults > > > > "Parser-level defaults ca

Re: [PATCH 3/3] patman: fix project-defaults not propagating into parsers

2020-11-26 Thread Philipp Tomsich
Simon, On Wed, 25 Nov 2020 at 16:30, Simon Glass wrote: > Here is a pointer to the docs I saw: > > https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.set_defaults > > "Parser-level defaults can be particularly useful when working with > multiple parsers. See the add_subparser

Re: [PATCH 3/3] patman: fix project-defaults not propagating into parsers

2020-11-26 Thread Philipp Tomsich
Simon, On Wed, 25 Nov 2020 at 00:41, Simon Glass wrote: > According to the Python documentation and my testing, it should > propagate. Do you know what is going wrong here? If there is a > problem, we should update the comment. I don't see any code for propagating this in the argparse module:

Re: [PATCH 3/3] patman: fix project-defaults not propagating into parsers

2020-11-26 Thread Philipp Tomsich
Simon, On Wed, 25 Nov 2020 at 00:41, Simon Glass wrote: > > > Project defaults (e.g. for linux and gcc) do not propagate into the > > subparsers. As both the processing of tags (e.g. in the defaults > > for the linux project) and supressing the signoff (in the defaults > > for the gcc project) a

Re: [PATCH 3/3] patman: fix project-defaults not propagating into parsers

2020-11-25 Thread Simon Glass
Hi Philipp, On Wed, 25 Nov 2020 at 06:02, Philipp Tomsich wrote: > > Simon, > > On Wed, 25 Nov 2020 at 00:41, Simon Glass wrote: > > According to the Python documentation and my testing, it should > > propagate. Do you know what is going wrong here? If there is a > > problem, we should update th

Re: [PATCH 3/3] patman: fix project-defaults not propagating into parsers

2020-11-24 Thread Simon Glass
Hi Philipp, On Tue, 24 Nov 2020 at 10:15, Philipp Tomsich wrote: > > Project defaults (e.g. for linux and gcc) do not propagate into the > subparsers. As both the processing of tags (e.g. in the defaults > for the linux project) and supressing the signoff (in the defaults > for the gcc project)

[PATCH 3/3] patman: fix project-defaults not propagating into parsers

2020-11-24 Thread Philipp Tomsich
Project defaults (e.g. for linux and gcc) do not propagate into the subparsers. As both the processing of tags (e.g. in the defaults for the linux project) and supressing the signoff (in the defaults for the gcc project) are settings from subparsers, these would still require an explicit commandli