Re: [PATCH 3/3] net: xilinx: Force a probe failure if it cannot setup phy

2022-02-09 Thread Andy Chiu
Dear Maintainers, I am sending this email to check if this patch was missed. I would be really appreciated if I get any suggestion from you, thanks! Best regards Andy On Thu, Jan 20, 2022 at 3:35 PM Andy Chiu wrote: > > Or we may get load access faults afterward. > > The `phydev` field on axi-e

[PATCH 3/3] net: xilinx: Force a probe failure if it cannot setup phy

2022-01-20 Thread Andy Chiu
Or we may get load access faults afterward. The `phydev` field on axi-ethernet’s private struct is not set on a failed phy_connect(): axi_emac_probe() => axiemac_phy_init() => priv->phydev = phy_connect() <--- may fail However, all of the following calls on `axi_emac_ops` assume a valid `phyd