Re: [PATCH 2/7] spi: sunxi: refactor SPI speed/mode programming

2022-07-18 Thread Andre Przywara
On Mon, 27 Jun 2022 23:43:25 -0400 Jesse Taube wrote: Hi Jesse, > On 6/27/22 20:31, Andre Przywara wrote: > > On Tue, 3 May 2022 22:20:35 +0100 > > Andre Przywara wrote: > > > > Hi, > > > >> As George rightfully pointed out [1], the spi-sunxi driver programs the > >> speed and mode setting

Re: [PATCH 2/7] spi: sunxi: refactor SPI speed/mode programming

2022-06-29 Thread Jesse Taube
On 6/27/22 20:31, Andre Przywara wrote: On Tue, 3 May 2022 22:20:35 +0100 Andre Przywara wrote: Hi, As George rightfully pointed out [1], the spi-sunxi driver programs the speed and mode settings only when the respective functions are called, but this gets lost over a call to release_bus(

Re: [PATCH 2/7] spi: sunxi: refactor SPI speed/mode programming

2022-06-27 Thread Jesse Taube
On 6/27/22 20:31, Andre Przywara wrote: On Tue, 3 May 2022 22:20:35 +0100 Andre Przywara wrote: Hi, As George rightfully pointed out [1], the spi-sunxi driver programs the speed and mode settings only when the respective functions are called, but this gets lost over a call to release_bus(

Re: [PATCH 2/7] spi: sunxi: refactor SPI speed/mode programming

2022-06-27 Thread Andre Przywara
On Tue, 3 May 2022 22:20:35 +0100 Andre Przywara wrote: Hi, > As George rightfully pointed out [1], the spi-sunxi driver programs the > speed and mode settings only when the respective functions are called, > but this gets lost over a call to release_bus(). That asserts the > reset line, thus f

[PATCH 2/7] spi: sunxi: refactor SPI speed/mode programming

2022-05-03 Thread Andre Przywara
As George rightfully pointed out [1], the spi-sunxi driver programs the speed and mode settings only when the respective functions are called, but this gets lost over a call to release_bus(). That asserts the reset line, thus forces each SPI register back to its default value. Adding to that, tryin