Re: [PATCH 2/5] cyclic: drop redundant cyclic_ready flag

2022-10-28 Thread Stefan Roese
On 28.10.22 13:50, Rasmus Villemoes wrote: We're already relying on gd->cyclic being NULL before cyclic_init() is called - i.e., we're relying on all of gd being zeroed before entering any C code. And when we do populate gd->cyclic, its ->cyclic_ready member is automatically set to true. So we ca

[PATCH 2/5] cyclic: drop redundant cyclic_ready flag

2022-10-28 Thread Rasmus Villemoes
We're already relying on gd->cyclic being NULL before cyclic_init() is called - i.e., we're relying on all of gd being zeroed before entering any C code. And when we do populate gd->cyclic, its ->cyclic_ready member is automatically set to true. So we can actually just rely on testing gd->cyclic it