Re: [PATCH 2/4] rng: msm: don't enable PRNG if it's already enabled

2025-01-31 Thread Sam Day
Hello (again) Neil, Fabio, On Friday, 31 January 2025 at 15:40, Sam Day wrote: > > Hi Neil, Fabio, > > On Friday, 31 January 2025 at 12:04, Sam Day m...@samcday.com wrote: > > > I'd love to take credit, but actually it was Stephan Gerhold who spotted > > this when we were debugging the issue

Re: [PATCH 2/4] rng: msm: don't enable PRNG if it's already enabled

2025-01-31 Thread Sam Day
Hi Neil, Fabio, On Friday, 31 January 2025 at 12:04, Sam Day wrote: > I'd love to take credit, but actually it was Stephan Gerhold who spotted > this when we were debugging the issue together :) > I got myself very confused here :) Stephan Gerhold helped me identify the issue fixed in patch #1

Re: [PATCH 2/4] rng: msm: don't enable PRNG if it's already enabled

2025-01-31 Thread Sam Day
Hello Fabio, On Friday, 31 January 2025 at 12:29, Fabio Estevam wrote: > > On Fri, Jan 31, 2025 at 8:10 AM Sam Day m...@samcday.com wrote: > > > I'd love to take credit, but actually it was Stephan Gerhold who spotted > > this when we were debugging the issue together :) > > > Maybe you could

Re: [PATCH 2/4] rng: msm: don't enable PRNG if it's already enabled

2025-01-31 Thread Fabio Estevam
On Fri, Jan 31, 2025 at 8:10 AM Sam Day wrote: > I'd love to take credit, but actually it was Stephan Gerhold who spotted > this when we were debugging the issue together :) Maybe you could add a Suggested-by tag.

Re: [PATCH 2/4] rng: msm: don't enable PRNG if it's already enabled

2025-01-31 Thread Sam Day
Hi Neil, On Friday, 31 January 2025 at 10:42, Neil Armstrong wrote: > > > On 27/01/2025 08:49, Sam Day wrote: > > > msm_rng_enable is supposed to skip writing to LFSR_CFG + CONFIG > > registers in the PRNG_ block if PRNG_CONFIG_HW_ENABLE is already set. > > The logic to test for this was inv

Re: [PATCH 2/4] rng: msm: don't enable PRNG if it's already enabled

2025-01-31 Thread Neil Armstrong
On 27/01/2025 08:49, Sam Day wrote: msm_rng_enable is supposed to skip writing to LFSR_CFG + CONFIG registers in the PRNG_ block if PRNG_CONFIG_HW_ENABLE is already set. The logic to test for this was inverted. Without this fix, the driver was causing SError aborts on my MSM8916 device. Stephan

[PATCH 2/4] rng: msm: don't enable PRNG if it's already enabled

2025-01-27 Thread Sam Day
msm_rng_enable is supposed to skip writing to LFSR_CFG + CONFIG registers in the PRNG_ block if PRNG_CONFIG_HW_ENABLE is already set. The logic to test for this was inverted. Without this fix, the driver was causing SError aborts on my MSM8916 device. Stephan Gerhold suggested this was probably be