[v7 PATCH 2/3] tpm: use more algorithms than sha256 on pcr_read

2021-11-26 Thread Ruchika Gupta
The current tpm2_pcr_read is hardcoded using SHA256. Make the actual command to TPM configurable to use wider range of algorithms. The current command line is kept as is i.e limited to SHA-256 only. Signed-off-by: Ruchika Gupta Reviewed-by: Ilias Apalodimas --- v7: No change v6: No change v5:

Re: [v3][PATCH 2/3] tpm: use more algorithms than sha256 on pcr_read

2021-11-24 Thread Ilias Apalodimas
On Wed, Nov 24, 2021 at 01:26:24PM +0530, Ruchika Gupta wrote: > The current tpm2_pcr_read is hardcoded using SHA256. Make the > actual command to TPM configurable to use wider range of algorithms. > The current command line is kept as is i.e limited to SHA-256 only. > > Signed-off-by: Ruchika Gup

Re: [v2] [PATCH 2/3] tpm: use more algorithms than sha256 on pcr_read

2021-11-24 Thread Ilias Apalodimas
On Tue, Nov 23, 2021 at 05:23:34PM +0530, Ruchika Gupta wrote: > The current tpm2_pcr_read is hardcoded using SHA256. Make the > actual command to TPM configurable to use wider range of algorithms. > The current command line is kept as is i.e limited to SHA-256 only. > > Signed-off-by: Ruchika Gup

[v3][PATCH 2/3] tpm: use more algorithms than sha256 on pcr_read

2021-11-23 Thread Ruchika Gupta
The current tpm2_pcr_read is hardcoded using SHA256. Make the actual command to TPM configurable to use wider range of algorithms. The current command line is kept as is i.e limited to SHA-256 only. Signed-off-by: Ruchika Gupta --- v3: No change v2: Change algorithm from u32 to u16 Add parameter

Re: [v2] [PATCH 2/3] tpm: use more algorithms than sha256 on pcr_read

2021-11-23 Thread Ilias Apalodimas
On Tue, Nov 23, 2021 at 05:23:34PM +0530, Ruchika Gupta wrote: > The current tpm2_pcr_read is hardcoded using SHA256. Make the > actual command to TPM configurable to use wider range of algorithms. > The current command line is kept as is i.e limited to SHA-256 only. > > Signed-off-by: Ruchika Gup

[v2] [PATCH 2/3] tpm: use more algorithms than sha256 on pcr_read

2021-11-23 Thread Ruchika Gupta
The current tpm2_pcr_read is hardcoded using SHA256. Make the actual command to TPM configurable to use wider range of algorithms. The current command line is kept as is i.e limited to SHA-256 only. Signed-off-by: Ruchika Gupta --- v2: Change algorithm from u32 to u16 Add parameter description in

[v2] [PATCH 2/3] tpm: use more algorithms than sha256 on pcr_read

2021-11-23 Thread Ruchika Gupta
The current tpm2_pcr_read is hardcoded using SHA256. Make the actual command to TPM configurable to use wider range of algorithms. The current command line is kept as is i.e limited to SHA-256 only. Signed-off-by: Ruchika Gupta --- v2: Change algorithm from u32 to u16 Add parameter description in

Re: [PATCH 2/3] tpm: use more algorithms than sha256 on pcr_read

2021-11-22 Thread Ilias Apalodimas
Hi Ruchika, [...] > - void *data, unsigned int *updates); > + u32 algorithm, void *data, u32 digest_len, This goes into a tpm_u16() call. It doesn't break anything currently, but shouldn't we define this as u16 ? > + unsigned int *updates); > > /**

[PATCH 2/3] tpm: use more algorithms than sha256 on pcr_read

2021-11-17 Thread Ruchika Gupta
The current tpm2_pcr_read is hardcoded using SHA256. Make the actual command to TPM configurable to use wider range of algorithms. The current command line is kept as is i.e limited to SHA-256 only. Signed-off-by: Ruchika Gupta --- cmd/tpm-v2.c | 3 ++- include/tpm-v2.h | 3 ++- lib/tpm-v2