Re: [PATCH 2/3] buildman: Detect Kconfig loops

2021-10-21 Thread Simon Glass
Hi Stefano, On Thu, 21 Oct 2021 at 10:35, Stefano Babic wrote: > > Hi Simon, > > On 21.10.21 18:15, Tom Rini wrote: > > On Thu, Oct 21, 2021 at 10:09:56AM -0600, Simon Glass wrote: > >> Hi Tom, > >> > >> On Thu, 21 Oct 2021 at 06:13, Tom Rini wrote: > >>> > >>> On Tue, Oct 19, 2021 at 09:43:24PM

Re: [PATCH 2/3] buildman: Detect Kconfig loops

2021-10-21 Thread Stefano Babic
Hi Simon, On 21.10.21 18:15, Tom Rini wrote: On Thu, Oct 21, 2021 at 10:09:56AM -0600, Simon Glass wrote: Hi Tom, On Thu, 21 Oct 2021 at 06:13, Tom Rini wrote: On Tue, Oct 19, 2021 at 09:43:24PM -0600, Simon Glass wrote: Hex and int Kconfig options are supposed to have defaults. This is s

Re: [PATCH 2/3] buildman: Detect Kconfig loops

2021-10-21 Thread Tom Rini
On Thu, Oct 21, 2021 at 10:09:56AM -0600, Simon Glass wrote: > Hi Tom, > > On Thu, 21 Oct 2021 at 06:13, Tom Rini wrote: > > > > On Tue, Oct 19, 2021 at 09:43:24PM -0600, Simon Glass wrote: > > > > > Hex and int Kconfig options are supposed to have defaults. This is so we > > > can configure U-Bo

Re: [PATCH 2/3] buildman: Detect Kconfig loops

2021-10-21 Thread Simon Glass
Hi Tom, On Thu, 21 Oct 2021 at 06:13, Tom Rini wrote: > > On Tue, Oct 19, 2021 at 09:43:24PM -0600, Simon Glass wrote: > > > Hex and int Kconfig options are supposed to have defaults. This is so we > > can configure U-Boot without having to enter particular values for the > > items that don't hav

Re: [PATCH 2/3] buildman: Detect Kconfig loops

2021-10-21 Thread Tom Rini
On Tue, Oct 19, 2021 at 09:43:24PM -0600, Simon Glass wrote: > Hex and int Kconfig options are supposed to have defaults. This is so we > can configure U-Boot without having to enter particular values for the > items that don't have specific values in the board's defconfig file. That's not true.

[PATCH 2/3] buildman: Detect Kconfig loops

2021-10-19 Thread Simon Glass
Hex and int Kconfig options are supposed to have defaults. This is so we can configure U-Boot without having to enter particular values for the items that don't have specific values in the board's defconfig file. If this rule is not followed, then introducing a new Kconfig can produce a loop like