Re: [PATCH 2/2] udoo_neo: Select DM_SERIAL

2022-11-14 Thread Fabio Estevam
On Mon, Nov 14, 2022 at 2:51 PM Peter Robinson wrote: > Yes, I realised that, I was going to do a follow up patch like some of > the other conversions I'd seen, but I'm reviewing a few other bits > while I'm at it. It is OK to do that on incremental patches, thanks.

Re: [PATCH 2/2] udoo_neo: Select DM_SERIAL

2022-11-14 Thread Peter Robinson
On Mon, Nov 14, 2022 at 5:34 PM Fabio Estevam wrote: > > On Mon, Nov 14, 2022 at 1:15 PM Peter Robinson wrote: > > > > The conversion to DM_SERIAL is mandatory, so select this > > option. > > After converting it to DM_SERIAL, the setup_iomux_uart() could be removed. > > With that removed: Yes, I

Re: [PATCH 2/2] udoo_neo: Select DM_SERIAL

2022-11-14 Thread Fabio Estevam
On Mon, Nov 14, 2022 at 1:15 PM Peter Robinson wrote: > > The conversion to DM_SERIAL is mandatory, so select this > option. After converting it to DM_SERIAL, the setup_iomux_uart() could be removed. With that removed: Reviewed-by: Fabio Estevam

[PATCH 2/2] udoo_neo: Select DM_SERIAL

2022-11-14 Thread Peter Robinson
The conversion to DM_SERIAL is mandatory, so select this option. Signed-off-by: Peter Robinson --- configs/udoo_neo_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/udoo_neo_defconfig b/configs/udoo_neo_defconfig index 6c29f8fd251..0c60e4a6f4a 100644 --- a/configs/udoo_neo_d