Re: [PATCH 2/2] tpm: add support for TPMv2.x I2C chips

2022-05-27 Thread Ilias Apalodimas
On Fri, 27 May 2022 at 10:26, Joel Stanley wrote: > > On Mon, 23 May 2022 at 13:25, Ilias Apalodimas > wrote: > > > > On Mon, May 23, 2022 at 08:19:51AM -0500, Eddie James wrote: > > > Yes, I think so. I tested with an older u-boot (openbmc uses a modified > > > v2019.04) with all the TPM core pa

Re: [PATCH 2/2] tpm: add support for TPMv2.x I2C chips

2022-05-27 Thread Joel Stanley
On Mon, 23 May 2022 at 13:25, Ilias Apalodimas wrote: > > On Mon, May 23, 2022 at 08:19:51AM -0500, Eddie James wrote: > > Yes, I think so. I tested with an older u-boot (openbmc uses a modified > > v2019.04) with all the TPM core patches, and I think I missed this bit in > > rebasing. > > No worr

Re: [PATCH 2/2] tpm: add support for TPMv2.x I2C chips

2022-05-23 Thread Ilias Apalodimas
On Mon, May 23, 2022 at 08:19:51AM -0500, Eddie James wrote: > > On 5/23/22 01:12, Ilias Apalodimas wrote: > > Hi Eddie, > > > > Thanks for the patch. > > > > [...] > > > > > +static const struct tpm_tis_chip_data tpm_tis_std_chip_data = { > > > + .pcr_count = 24, > > > + .pcr_select_min = 3, >

Re: [PATCH 2/2] tpm: add support for TPMv2.x I2C chips

2022-05-23 Thread Eddie James
On 5/23/22 01:12, Ilias Apalodimas wrote: Hi Eddie, Thanks for the patch. [...] +static const struct tpm_tis_chip_data tpm_tis_std_chip_data = { + .pcr_count = 24, + .pcr_select_min = 3, +}; + +static const struct udevice_id tpm_tis_i2c_ids[] = { + { + .compa

Re: [PATCH 2/2] tpm: add support for TPMv2.x I2C chips

2022-05-22 Thread Ilias Apalodimas
Hi Eddie, Thanks for the patch. [...] > +static const struct tpm_tis_chip_data tpm_tis_std_chip_data = { > + .pcr_count = 24, > + .pcr_select_min = 3, > +}; > + > +static const struct udevice_id tpm_tis_i2c_ids[] = { > + { > + .compatible = "nuvoton,npct75x", > +

Re: [PATCH 2/2] tpm: add support for TPMv2.x I2C chips

2022-05-18 Thread Joel Stanley
On Fri, 13 May 2022 at 18:30, Eddie James wrote: > > Add the tpm2_tis_i2c driver that should support any TPMv2 compliant > I2C chips, such as the NPCT75X chip. > > Signed-off-by: Eddie James > --- > drivers/tpm/Kconfig| 9 ++ > drivers/tpm/Makefile | 1 + > drivers/tpm/tpm2_tis

[PATCH 2/2] tpm: add support for TPMv2.x I2C chips

2022-05-13 Thread Eddie James
Add the tpm2_tis_i2c driver that should support any TPMv2 compliant I2C chips, such as the NPCT75X chip. Signed-off-by: Eddie James --- drivers/tpm/Kconfig| 9 ++ drivers/tpm/Makefile | 1 + drivers/tpm/tpm2_tis_i2c.c | 171 + 3 files changed