Re: [PATCH 2/2] test/py: efi_secboot: adjust secure boot tests to code changes

2022-02-16 Thread Ilias Apalodimas
Akashi-san, Here's an example of what was not working in case it helps you understand [...] > > > > > > > > > > > When you said "in a reversed order" in your commit, I expected that > > > > either > > > > 1.the image(helloworld.efi) has two signatures in a reversed order, or > > > >(You

Re: [PATCH 2/2] test/py: efi_secboot: adjust secure boot tests to code changes

2022-02-16 Thread Ilias Apalodimas
On Wed, 16 Feb 2022 at 04:20, AKASHI Takahiro wrote: > > Heinrich, > > We (I and Ilias) are still discussing on this patch. > I don't think it appropriate to merge it (in -rc2) at this point. I think it's fine to keep this as is since it's actually testing for a case that the patch fixed. I'll s

Re: [PATCH 2/2] test/py: efi_secboot: adjust secure boot tests to code changes

2022-02-16 Thread Ilias Apalodimas
On Wed, 16 Feb 2022 at 04:18, AKASHI Takahiro wrote: > > Ilias, > > On Tue, Feb 15, 2022 at 08:50:08AM +0200, Ilias Apalodimas wrote: > > Akashi-san, > > > > > > > > > > > > > > > > > > +# Try rejection in reverse order. > > > > > > > > > > > > > > "Reverse order" of what? > > > > > > > >

Re: [PATCH 2/2] test/py: efi_secboot: adjust secure boot tests to code changes

2022-02-15 Thread AKASHI Takahiro
Heinrich, We (I and Ilias) are still discussing on this patch. I don't think it appropriate to merge it (in -rc2) at this point. -Takahiro Akashi On Fri, Feb 11, 2022 at 09:37:50AM +0200, Ilias Apalodimas wrote: > The previous patch is changing U-Boot's behavior wrt certificate based > binary au

Re: [PATCH 2/2] test/py: efi_secboot: adjust secure boot tests to code changes

2022-02-15 Thread AKASHI Takahiro
Ilias, On Tue, Feb 15, 2022 at 08:50:08AM +0200, Ilias Apalodimas wrote: > Akashi-san, > > > > > > > > > > > > > > > +# Try rejection in reverse order. > > > > > > > > > > > > "Reverse order" of what? > > > > > > > > > > Of the test right above > > > > > > > > Please specify the sign

Re: [PATCH 2/2] test/py: efi_secboot: adjust secure boot tests to code changes

2022-02-14 Thread Ilias Apalodimas
Akashi-san, > > > > > > > > > > > > +# Try rejection in reverse order. > > > > > > > > > > "Reverse order" of what? > > > > > > > > Of the test right above > > > > > > Please specify the signature database, I guess "dbx"? > > > > > > > > > > > > > > +u_boot_console.restart_u

Re: [PATCH 2/2] test/py: efi_secboot: adjust secure boot tests to code changes

2022-02-14 Thread AKASHI Takahiro
On Mon, Feb 14, 2022 at 08:56:07AM +0200, Ilias Apalodimas wrote: > On Mon, Feb 14, 2022 at 03:36:06PM +0900, AKASHI Takahiro wrote: > > On Mon, Feb 14, 2022 at 08:18:03AM +0200, Ilias Apalodimas wrote: > > > On Mon, Feb 14, 2022 at 10:50:08AM +0900, AKASHI Takahiro wrote: > > > > Ilias, > > > > >

Re: [PATCH 2/2] test/py: efi_secboot: adjust secure boot tests to code changes

2022-02-13 Thread Ilias Apalodimas
On Mon, Feb 14, 2022 at 03:36:06PM +0900, AKASHI Takahiro wrote: > On Mon, Feb 14, 2022 at 08:18:03AM +0200, Ilias Apalodimas wrote: > > On Mon, Feb 14, 2022 at 10:50:08AM +0900, AKASHI Takahiro wrote: > > > Ilias, > > > > > > On Fri, Feb 11, 2022 at 09:37:50AM +0200, Ilias Apalodimas wrote: > > >

Re: [PATCH 2/2] test/py: efi_secboot: adjust secure boot tests to code changes

2022-02-13 Thread AKASHI Takahiro
On Mon, Feb 14, 2022 at 08:18:03AM +0200, Ilias Apalodimas wrote: > On Mon, Feb 14, 2022 at 10:50:08AM +0900, AKASHI Takahiro wrote: > > Ilias, > > > > On Fri, Feb 11, 2022 at 09:37:50AM +0200, Ilias Apalodimas wrote: > > > The previous patch is changing U-Boot's behavior wrt certificate based > >

Re: [PATCH 2/2] test/py: efi_secboot: adjust secure boot tests to code changes

2022-02-13 Thread Ilias Apalodimas
On Mon, Feb 14, 2022 at 10:50:08AM +0900, AKASHI Takahiro wrote: > Ilias, > > On Fri, Feb 11, 2022 at 09:37:50AM +0200, Ilias Apalodimas wrote: > > The previous patch is changing U-Boot's behavior wrt certificate based > > binary authentication. Specifically an image who's digest of a > > certifi

Re: [PATCH 2/2] test/py: efi_secboot: adjust secure boot tests to code changes

2022-02-13 Thread AKASHI Takahiro
Ilias, On Fri, Feb 11, 2022 at 09:37:50AM +0200, Ilias Apalodimas wrote: > The previous patch is changing U-Boot's behavior wrt certificate based > binary authentication. Specifically an image who's digest of a > certificate is found in dbx is now rejected. Fix the test accordingly > and add ano

[PATCH 2/2] test/py: efi_secboot: adjust secure boot tests to code changes

2022-02-10 Thread Ilias Apalodimas
The previous patch is changing U-Boot's behavior wrt certificate based binary authentication. Specifically an image who's digest of a certificate is found in dbx is now rejected. Fix the test accordingly and add another one testing signatures in reverse order Signed-off-by: Ilias Apalodimas ---

Re: [RFC PATCH 2/2] test/py: efi_secboot: adjust secure boot tests to code changes

2022-02-10 Thread Ilias Apalodimas
Akashi-san On Thu, 10 Feb 2022 at 09:31, AKASHI Takahiro wrote: > > On Thu, Feb 10, 2022 at 09:14:25AM +0200, Ilias Apalodimas wrote: > > Akashi-san > > > > On Thu, 10 Feb 2022 at 07:22, AKASHI Takahiro > > wrote: > > > > > > On Fri, Feb 04, 2022 at 09:32:02AM +0200, Ilias Apalodimas wrote: > >

Re: [RFC PATCH 2/2] test/py: efi_secboot: adjust secure boot tests to code changes

2022-02-09 Thread AKASHI Takahiro
On Thu, Feb 10, 2022 at 09:14:25AM +0200, Ilias Apalodimas wrote: > Akashi-san > > On Thu, 10 Feb 2022 at 07:22, AKASHI Takahiro > wrote: > > > > On Fri, Feb 04, 2022 at 09:32:02AM +0200, Ilias Apalodimas wrote: > > > The previous patch is changing U-Boot's behavior wrt certificate based > > > bi

Re: [RFC PATCH 2/2] test/py: efi_secboot: adjust secure boot tests to code changes

2022-02-09 Thread Ilias Apalodimas
Akashi-san On Thu, 10 Feb 2022 at 07:22, AKASHI Takahiro wrote: > > On Fri, Feb 04, 2022 at 09:32:02AM +0200, Ilias Apalodimas wrote: > > The previous patch is changing U-Boot's behavior wrt certificate based > > binary authentication. Specifically an image who's digest of a > > certificate is f

Re: [RFC PATCH 2/2] test/py: efi_secboot: adjust secure boot tests to code changes

2022-02-09 Thread AKASHI Takahiro
On Fri, Feb 04, 2022 at 09:32:02AM +0200, Ilias Apalodimas wrote: > The previous patch is changing U-Boot's behavior wrt certificate based > binary authentication. Specifically an image who's digest of a > certificate is found in dbx is now rejected. Fix the test accordingly Please not only fix

[RFC PATCH 2/2] test/py: efi_secboot: adjust secure boot tests to code changes

2022-02-03 Thread Ilias Apalodimas
The previous patch is changing U-Boot's behavior wrt certificate based binary authentication. Specifically an image who's digest of a certificate is found in dbx is now rejected. Fix the test accordingly Signed-off-by: Ilias Apalodimas --- test/py/tests/test_efi_secboot/test_signed.py | 5 +++-