Re: [PATCH 2/2] arm64: a37xx: pci: Assert PERST# signal when unloading driver

2020-08-31 Thread Stefan Roese
On 19.08.20 15:57, Pali Rohár wrote: This change ensures that PCIe card is put into reset state when U-Boot stops using it. DM_FLAG_OS_PREPARE ensures that U-Boot executes driver's remove callback prior booting Linux kernel. Linux kernel pci-aardvark driver needs to reset PCIe card via PERST# s

Re: [PATCH 2/2] arm64: a37xx: pci: Assert PERST# signal when unloading driver

2020-08-27 Thread Andre Heider
On 19/08/2020 15:57, Pali Rohár wrote: This change ensures that PCIe card is put into reset state when U-Boot stops using it. DM_FLAG_OS_PREPARE ensures that U-Boot executes driver's remove callback prior booting Linux kernel. Linux kernel pci-aardvark driver needs to reset PCIe card via PERST#

Re: [PATCH 2/2] arm64: a37xx: pci: Assert PERST# signal when unloading driver

2020-08-25 Thread Stefan Roese
On 25.08.20 10:46, Pali Rohár wrote: On Thursday 20 August 2020 10:00:52 Stefan Roese wrote: I suggest to "depend" this driver on DM_GPIO and include the GPIO code without any #ifdef's. And please run a world-build (buildman, Travis...) to see, if nothing breaks. I sent third patch which remov

Re: [PATCH 2/2] arm64: a37xx: pci: Assert PERST# signal when unloading driver

2020-08-25 Thread Pali Rohár
On Thursday 20 August 2020 10:00:52 Stefan Roese wrote: > I suggest to "depend" this driver on DM_GPIO and include the GPIO code > without any #ifdef's. And please run a world-build (buildman, Travis...) > to see, if nothing breaks. I sent third patch which removes those #ifdef's and run CI testin

RE: [EXT] [PATCH 2/2] arm64: a37xx: pci: Assert PERST# signal when unloading driver

2020-08-20 Thread Kostya Porotchkin
> -Original Message- > From: Pali Rohár > Sent: Wednesday, August 19, 2020 16:57 > To: Stefan Roese ; Kostya Porotchkin > Cc: u-boot@lists.denx.de > Subject: [EXT] [PATCH 2/2] arm64: a37xx: pci: Assert PERST# signal when > unloading drive

Re: [PATCH 2/2] arm64: a37xx: pci: Assert PERST# signal when unloading driver

2020-08-20 Thread Stefan Roese
On 20.08.20 09:52, Pali Rohár wrote: On Thursday 20 August 2020 09:48:17 Stefan Roese wrote: On 20.08.20 09:43, Pali Rohár wrote: On Thursday 20 August 2020 07:05:58 Stefan Roese wrote: On 19.08.20 15:57, Pali Rohár wrote: This change ensures that PCIe card is put into reset state when U-Boot

Re: [EXT] [PATCH 2/2] arm64: a37xx: pci: Assert PERST# signal when unloading driver

2020-08-20 Thread Stefan Roese
: a37xx: pci: Assert PERST# signal when unloading driver External Email -- This change ensures that PCIe card is put into reset state when U-Boot stops using it. DM_FLAG_OS_PREPARE ensures that U-Boot executes driver's r

Re: [PATCH 2/2] arm64: a37xx: pci: Assert PERST# signal when unloading driver

2020-08-20 Thread Pali Rohár
On Thursday 20 August 2020 09:48:17 Stefan Roese wrote: > On 20.08.20 09:43, Pali Rohár wrote: > > On Thursday 20 August 2020 07:05:58 Stefan Roese wrote: > > > On 19.08.20 15:57, Pali Rohár wrote: > > > > This change ensures that PCIe card is put into reset state when U-Boot > > > > stops using it

Re: [PATCH 2/2] arm64: a37xx: pci: Assert PERST# signal when unloading driver

2020-08-20 Thread Stefan Roese
On 20.08.20 09:43, Pali Rohár wrote: On Thursday 20 August 2020 07:05:58 Stefan Roese wrote: On 19.08.20 15:57, Pali Rohár wrote: This change ensures that PCIe card is put into reset state when U-Boot stops using it. DM_FLAG_OS_PREPARE ensures that U-Boot executes driver's remove callback prio

Re: [PATCH 2/2] arm64: a37xx: pci: Assert PERST# signal when unloading driver

2020-08-20 Thread Pali Rohár
On Thursday 20 August 2020 07:05:58 Stefan Roese wrote: > On 19.08.20 15:57, Pali Rohár wrote: > > This change ensures that PCIe card is put into reset state when U-Boot > > stops using it. > > > > DM_FLAG_OS_PREPARE ensures that U-Boot executes driver's remove callback > > prior booting Linux ker

Re: [PATCH 2/2] arm64: a37xx: pci: Assert PERST# signal when unloading driver

2020-08-19 Thread Stefan Roese
On 19.08.20 15:57, Pali Rohár wrote: This change ensures that PCIe card is put into reset state when U-Boot stops using it. DM_FLAG_OS_PREPARE ensures that U-Boot executes driver's remove callback prior booting Linux kernel. Linux kernel pci-aardvark driver needs to reset PCIe card via PERST# s

Re: [EXT] [PATCH 2/2] arm64: a37xx: pci: Assert PERST# signal when unloading driver

2020-08-19 Thread Kostya Porotchkin
From: Pali Rohár Sent: Wednesday, August 19, 2020 16:57 To: Stefan Roese; Kostya Porotchkin Cc: u-boot@lists.denx.de Subject: [EXT] [PATCH 2/2] arm64: a37xx: pci: Assert PERST# signal when unloading driver External Email

[PATCH 2/2] arm64: a37xx: pci: Assert PERST# signal when unloading driver

2020-08-19 Thread Pali Rohár
This change ensures that PCIe card is put into reset state when U-Boot stops using it. DM_FLAG_OS_PREPARE ensures that U-Boot executes driver's remove callback prior booting Linux kernel. Linux kernel pci-aardvark driver needs to reset PCIe card via PERST# signal prior initializing it. If it does