Re: [PATCH 16/17] clk: Detect failure to set defaults

2021-05-10 Thread Sean Anderson
On 5/10/21 12:28 PM, Simon Glass wrote: Hi Sean, On Sat, 8 May 2021 at 18:40, Sean Anderson wrote: On 5/8/21 6:00 PM, Simon Glass wrote: When the default clocks cannot be set, the clock is silently probed and the error is ignored. This is incorrect, since having the clocks at the correct spe

Re: [PATCH 16/17] clk: Detect failure to set defaults

2021-05-10 Thread Simon Glass
Hi Sean, On Sat, 8 May 2021 at 18:40, Sean Anderson wrote: > > On 5/8/21 6:00 PM, Simon Glass wrote: > > When the default clocks cannot be set, the clock is silently probed and > > the error is ignored. This is incorrect, since having the clocks at the > > correct speed may be important for opera

Re: [PATCH 16/17] clk: Detect failure to set defaults

2021-05-08 Thread Sean Anderson
On 5/8/21 6:00 PM, Simon Glass wrote: When the default clocks cannot be set, the clock is silently probed and the error is ignored. This is incorrect, since having the clocks at the correct speed may be important for operation of the system. Fix it by checking the return code. Signed-off-by: Si

[PATCH 16/17] clk: Detect failure to set defaults

2021-05-08 Thread Simon Glass
When the default clocks cannot be set, the clock is silently probed and the error is ignored. This is incorrect, since having the clocks at the correct speed may be important for operation of the system. Fix it by checking the return code. Signed-off-by: Simon Glass --- drivers/clk/clk-uclass.