Re: [PATCH 16/16] efi_selftest: adjust runtime test for variables

2020-04-01 Thread AKASHI Takahiro
On Wed, Apr 01, 2020 at 08:37:38AM +0200, Heinrich Schuchardt wrote: > On 4/1/20 3:05 AM, AKASHI Takahiro wrote: > > On Tue, Mar 31, 2020 at 08:07:39AM +0200, Heinrich Schuchardt wrote: > >> As variable services are available at runtime we have to expect EFI_SUCCESS > >> when calling the services.

Re: [PATCH 16/16] efi_selftest: adjust runtime test for variables

2020-03-31 Thread Heinrich Schuchardt
On 4/1/20 3:05 AM, AKASHI Takahiro wrote: > On Tue, Mar 31, 2020 at 08:07:39AM +0200, Heinrich Schuchardt wrote: >> As variable services are available at runtime we have to expect EFI_SUCCESS >> when calling the services. > > Why not run variables test *after* ExitBootServices as well as > *before*

Re: [PATCH 16/16] efi_selftest: adjust runtime test for variables

2020-03-31 Thread AKASHI Takahiro
On Tue, Mar 31, 2020 at 08:07:39AM +0200, Heinrich Schuchardt wrote: > As variable services are available at runtime we have to expect EFI_SUCCESS > when calling the services. Why not run variables test *after* ExitBootServices as well as *before* that event? Then we should have more test cases.

[PATCH 16/16] efi_selftest: adjust runtime test for variables

2020-03-30 Thread Heinrich Schuchardt
As variable services are available at runtime we have to expect EFI_SUCCESS when calling the services. Check the SetVariable() only succeeds with EFI_VARIABLE_RUNTIME_ACCESS and EFI_VARIABLE_NON_VOLATILE set. Signed-off-by: Heinrich Schuchardt --- .../efi_selftest_variables_runtime.c |