Re: [PATCH 11/11] bootm: Support string substitution in bootargs

2020-11-03 Thread Simon Glass
Hi Wolfgang, On Thu, 22 Oct 2020 at 06:32, Wolfgang Denk wrote: > > Dear Simon, > > In message > you > wrote: > > > > Well my series does that to a large extent. It is much more like bootm > > now, in that it is properly split into stages. I think it would be > > possible to combine parts of i

Re: [PATCH 11/11] bootm: Support string substitution in bootargs

2020-10-22 Thread Wolfgang Denk
Dear Simon, In message you wrote: > > Well my series does that to a large extent. It is much more like bootm > now, in that it is properly split into stages. I think it would be > possible to combine parts of it into bootm as a future step, although > it is non-trivial, and I think we should bui

Re: [PATCH 11/11] bootm: Support string substitution in bootargs

2020-10-21 Thread Simon Glass
Hi Wolfgang, On Wed, 21 Oct 2020 at 01:16, Wolfgang Denk wrote: > > Dear Simon, > > In message > you > wrote: > > > > > Yes, it takes one additional step, but it's simple and does not need > > > extra code. > > > > It is actually not simple, for three reasons: > > > > 1. With zboot the args co

Re: [PATCH 11/11] bootm: Support string substitution in bootargs

2020-10-21 Thread Wolfgang Denk
Dear Simon, In message you wrote: > > > Yes, it takes one additional step, but it's simple and does not need > > extra code. > > It is actually not simple, for three reasons: > > 1. With zboot the args come from the kernel setup.bin and must be modified Don't use zboot, then. In my opinion, zb

Re: [PATCH 11/11] bootm: Support string substitution in bootargs

2020-10-20 Thread Simon Glass
Hi Wolfgang, On Tue, 20 Oct 2020 at 07:26, Wolfgang Denk wrote: > > Dear Simon, > > In message > you > wrote: > > > > > At the moment we have some cumbersome constructs like > > >set_bootargs="setenv bootargs bla ${var}" > > > > Yes it is a real pain. The substitution happens on first pars

Re: [PATCH 11/11] bootm: Support string substitution in bootargs

2020-10-20 Thread Simon Glass
Hi Wolfgang, On Tue, 20 Oct 2020 at 07:17, Wolfgang Denk wrote: > > Dear Simon, > > In message > you > wrote: > > > > > You add something unconditionally to common code which very few > > > people need. U-Boot size is growing all the time because of such > > > ... features. This may be accep

Re: [PATCH 11/11] bootm: Support string substitution in bootargs

2020-10-20 Thread Wolfgang Denk
Dear Simon, In message you wrote: > > > At the moment we have some cumbersome constructs like > >set_bootargs="setenv bootargs bla ${var}" > > Yes it is a real pain. The substitution happens on first parse two, so > you have to put these commands in separate variables if you are > building t

Re: [PATCH 11/11] bootm: Support string substitution in bootargs

2020-10-20 Thread Wolfgang Denk
Dear Simon, In message you wrote: > > I did wonder about the empty env var thing. IMO it would be nice to > support empty variables, so we can distinguish between an empty one > and a missing one. What exactly is the use case for this that justifies the additional code needed to implement this

Re: [PATCH 11/11] bootm: Support string substitution in bootargs

2020-10-20 Thread Wolfgang Denk
Dear Simon, In message you wrote: > > > You add something unconditionally to common code which very few > > people need. U-Boot size is growing all the time because of such > > ... features. This may be acceptable on the systems you have in > > mind, but I consider this selfish. > > Did you se

Re: [PATCH 11/11] bootm: Support string substitution in bootargs

2020-10-19 Thread Simon Glass
Hi Michael, On Mon, 19 Oct 2020 at 09:47, Michael Walle wrote: > > Am 2020-10-19 16:54, schrieb Wolfgang Denk: > > Dear Simon, > > > > In message <20201019135602.3943835-12-...@chromium.org> you wrote: > >> In some cases it is necessary to pass parameters to Linux so that it > >> will > >> boot c

Re: [PATCH 11/11] bootm: Support string substitution in bootargs

2020-10-19 Thread Simon Glass
Hi Wolfgang, On Mon, 19 Oct 2020 at 08:55, Wolfgang Denk wrote: > > Dear Simon, > > In message <20201019135602.3943835-12-...@chromium.org> you wrote: > > In some cases it is necessary to pass parameters to Linux so that it will > > boot correctly. For example, the rootdev parameter is often used

Re: [PATCH 11/11] bootm: Support string substitution in bootargs

2020-10-19 Thread Simon Glass
Hi Rasmus, On Mon, 19 Oct 2020 at 08:43, Rasmus Villemoes wrote: > > On 19/10/2020 15.56, Simon Glass wrote: > > In some cases it is necessary to pass parameters to Linux so that it will > > boot correctly. For example, the rootdev parameter is often used to > > specify the root device. However t

Re: [PATCH 11/11] bootm: Support string substitution in bootargs

2020-10-19 Thread Michael Walle
Am 2020-10-19 16:54, schrieb Wolfgang Denk: Dear Simon, In message <20201019135602.3943835-12-...@chromium.org> you wrote: In some cases it is necessary to pass parameters to Linux so that it will boot correctly. For example, the rootdev parameter is often used to specify the root device. Howe

Re: [PATCH 11/11] bootm: Support string substitution in bootargs

2020-10-19 Thread Wolfgang Denk
Dear Simon, In message <20201019135602.3943835-12-...@chromium.org> you wrote: > In some cases it is necessary to pass parameters to Linux so that it will > boot correctly. For example, the rootdev parameter is often used to > specify the root device. However the root device may change depending o

Re: [PATCH 11/11] bootm: Support string substitution in bootargs

2020-10-19 Thread Rasmus Villemoes
On 19/10/2020 15.56, Simon Glass wrote: > In some cases it is necessary to pass parameters to Linux so that it will > boot correctly. For example, the rootdev parameter is often used to > specify the root device. However the root device may change depending on > whence U-Boot loads the kernel. At p

[PATCH 11/11] bootm: Support string substitution in bootargs

2020-10-19 Thread Simon Glass
In some cases it is necessary to pass parameters to Linux so that it will boot correctly. For example, the rootdev parameter is often used to specify the root device. However the root device may change depending on whence U-Boot loads the kernel. At present it is necessary to build up the command l