Re: [PATCH 10/25] binman: Move section-building code into a function

2021-01-23 Thread Simon Glass
Hi Alper, On Wed, 4 Nov 2020 at 14:51, Alper Nebi Yasak wrote: > > On 03/11/2020 18:11, Simon Glass wrote: > > Hi Alper, > > > > On Mon, 26 Oct 2020 at 17:20, Alper Nebi Yasak > > wrote: > >> > >> On 26/10/2020 22:22, Simon Glass wrote: > >>> I've added a few test cases along these lines in v2,

Re: [PATCH 10/25] binman: Move section-building code into a function

2020-11-04 Thread Alper Nebi Yasak
On 03/11/2020 18:11, Simon Glass wrote: > Hi Alper, > > On Mon, 26 Oct 2020 at 17:20, Alper Nebi Yasak > wrote: >> >> On 26/10/2020 22:22, Simon Glass wrote: >>> I've added a few test cases along these lines in v2, and one of them >>> certainly different behaviour. This is good actually since it

Re: [PATCH 10/25] binman: Move section-building code into a function

2020-11-03 Thread Simon Glass
Hi Alper, On Mon, 26 Oct 2020 at 17:20, Alper Nebi Yasak wrote: > > On 26/10/2020 22:22, Simon Glass wrote: > > On Mon, 19 Oct 2020 at 15:29, Alper Nebi Yasak > > wrote: > >> On 19/10/2020 05:41, Simon Glass wrote: > >>> for entry in self._entries.values(): > >>> data = en

Re: [PATCH 10/25] binman: Move section-building code into a function

2020-10-26 Thread Alper Nebi Yasak
On 26/10/2020 22:22, Simon Glass wrote: > On Mon, 19 Oct 2020 at 15:29, Alper Nebi Yasak > wrote: >> On 19/10/2020 05:41, Simon Glass wrote: >>> for entry in self._entries.values(): >>> data = entry.GetData() >>> -base = self.pad_before + (entry.offset or 0) - >

Re: [PATCH 10/25] binman: Move section-building code into a function

2020-10-26 Thread Simon Glass
Hi Alper, On Mon, 19 Oct 2020 at 15:29, Alper Nebi Yasak wrote: > > On 19/10/2020 05:41, Simon Glass wrote: > > Create a new _BuildSectionData() to hold the code that is now in > > GetData(), so that it is clearly separated from entry.GetData() base > > function. > > > > Separate out the 'pad-bef

Re: [PATCH 10/25] binman: Move section-building code into a function

2020-10-19 Thread Alper Nebi Yasak
On 19/10/2020 05:41, Simon Glass wrote: > Create a new _BuildSectionData() to hold the code that is now in > GetData(), so that it is clearly separated from entry.GetData() base > function. > > Separate out the 'pad-before' processing to make this easier to > understand. > > Unfortunately this br

[PATCH 10/25] binman: Move section-building code into a function

2020-10-18 Thread Simon Glass
Create a new _BuildSectionData() to hold the code that is now in GetData(), so that it is clearly separated from entry.GetData() base function. Separate out the 'pad-before' processing to make this easier to understand. Unfortunately this breaks the testDual test. Rather than squash several patch