Re: [PATCH 1/8] disk: Drop always true conditional check

2023-08-23 Thread Tom Rini
On Mon, Aug 14, 2023 at 01:46:41AM +0200, Marek Vasut wrote: > if (device_get_uclass_id(dev) == UCLASS_PARTITION) is always > true, because this disk_blk_read() function calls dev_get_blk() > above and checks its return value for non-NULL. The dev_get_blk() > performs the same device_get_uclass_id

[PATCH 1/8] disk: Drop always true conditional check

2023-08-13 Thread Marek Vasut
if (device_get_uclass_id(dev) == UCLASS_PARTITION) is always true, because this disk_blk_read() function calls dev_get_blk() above and checks its return value for non-NULL. The dev_get_blk() performs the same device_get_uclass_id(dev) check and returns NULL if not UCLASS_PARTITION. Drop the duplica