Re: [PATCH 1/6 v4] tpm2: Introduce TIS tpm core

Hi Ilias, On Fri, 5 Nov 2021 at 01:02, Ilias Apalodimas wrote: > > Hi Simon, > > [...] > > > > > > +int tpm_tis_open(struct udevice *udev); > > > > Please add comments > > There are comments for all of those in drivers/tpm/tpm2_tis_core.c, > isn't that enough? So just move them to the header fil

Re: [PATCH 1/6 v4] tpm2: Introduce TIS tpm core

Hi Simon, [...] > > > > +int tpm_tis_open(struct udevice *udev); > > Please add comments There are comments for all of those in drivers/tpm/tpm2_tis_core.c, isn't that enough? Thanks /Ilias > > > +int tpm_tis_close(struct udevice *udev); > > +int tpm_tis_cleanup(struct udevice *udev); > > +int t

Re: [PATCH 1/6 v4] tpm2: Introduce TIS tpm core

Hi Ilias, On Wed, 3 Nov 2021 at 09:09, Ilias Apalodimas wrote: > > There's a lot of code duplication in U-Boot right now. All the TPM TIS > compatible drivers we have at the moment have their own copy of a TIS > implementation. > > So let's create a common layer which implements the core TIS fun

[PATCH 1/6 v4] tpm2: Introduce TIS tpm core

There's a lot of code duplication in U-Boot right now. All the TPM TIS compatible drivers we have at the moment have their own copy of a TIS implementation. So let's create a common layer which implements the core TIS functions. Any driver added from now own, which is compatible with the TIS spec