Re: [PATCH 1/4] lib: sha256: add feature sha256_hmac

2024-07-23 Thread Philippe REYNES
Hi Tom, Le 17/07/2024 à 19:58, Tom Rini a écrit : On Wed, Jul 17, 2024 at 07:08:27PM +0200, Philippe REYNES wrote: Hi Peter, Le 16/07/2024 à 18:56, Peter Robinson a écrit : This Mail comes from Outside of SoftAtHome: Do not answer, click links or open attachments unless you recognize the se

Re: [PATCH 1/4] lib: sha256: add feature sha256_hmac

2024-07-17 Thread Tom Rini
On Wed, Jul 17, 2024 at 07:08:27PM +0200, Philippe REYNES wrote: > Hi Peter, > > Le 16/07/2024 à 18:56, Peter Robinson a écrit : > > This Mail comes from Outside of SoftAtHome: Do not answer, click links or > > open attachments unless you recognize the sender and know the content is > > safe. >

Re: [PATCH 1/4] lib: sha256: add feature sha256_hmac

2024-07-17 Thread Philippe REYNES
Hi Peter, Le 16/07/2024 à 18:56, Peter Robinson a écrit : This Mail comes from Outside of SoftAtHome: Do not answer, click links or open attachments unless you recognize the sender and know the content is safe. Hi Philippe, It might be useful to have a cover letter explaining what the plans f

Re: [PATCH 1/4] lib: sha256: add feature sha256_hmac

2024-07-16 Thread Peter Robinson
Hi Philippe, It might be useful to have a cover letter explaining what the plans for this code are, great that there are tests but adding code in without it being used isn't always a feature so a cover letter with some details often helps with the context. Also if you're not aware there's work to

[PATCH 1/4] lib: sha256: add feature sha256_hmac

2024-07-16 Thread Philippe Reynes
Adds the support of the hmac based on sha256. This implementation is based on rfc2104. Signed-off-by: Philippe Reynes --- include/u-boot/sha256.h | 4 lib/sha256.c| 40 2 files changed, 44 insertions(+) diff --git a/include/u-boot/sha25