Re: [PATCH 1/3] sunxi: psci: clean away preprocessor macros

2023-08-14 Thread Sam Edwards
On 8/14/23 15:05, Andre Przywara wrote: Yes, I will add this to the header file, either defined as 0, or to its actual address. Gotcha; my v2 will also assume you've taken care of merging these guys: +#define SUNXI_CPUX_BASE0x0901 +#define SUNXI_CPUCFG_BASE

Re: [PATCH 1/3] sunxi: psci: clean away preprocessor macros

2023-08-14 Thread Andre Przywara
On Mon, 14 Aug 2023 12:10:25 -0600 Sam Edwards wrote: > Hi Andre, > > On 8/14/23 10:37, Andre Przywara wrote: > > So I think we can get rid of this: > > - GEN_H6 never compiles this code here, as both H6 and H616 are arm64. > > Easy! > > > - We can define SUNXI_PRCM_BASE for NCAT2, I believe

Re: [PATCH 1/3] sunxi: psci: clean away preprocessor macros

2023-08-14 Thread Sam Edwards
Hi Andre, On 8/14/23 10:37, Andre Przywara wrote: So I think we can get rid of this: - GEN_H6 never compiles this code here, as both H6 and H616 are arm64. Easy! - We can define SUNXI_PRCM_BASE for NCAT2, I believe Samuel once mentioned that the D1/T113 does have such a block, actually. Wi

Re: [PATCH 1/3] sunxi: psci: clean away preprocessor macros

2023-08-14 Thread Andre Przywara
On Fri, 11 Aug 2023 18:30:53 -0600 Sam Edwards wrote: Hi Sam, many thanks for that cleanup, that's very much welcome! I am still comparing the outcome for the different SoC families, and testing this on the boards I have, but two things I stumbled upon already: > This patch restructures psci.c

[PATCH 1/3] sunxi: psci: clean away preprocessor macros

2023-08-11 Thread Sam Edwards
This patch restructures psci.c to get away from the "many different function definitions switched by #ifdef" paradigm to the preferred style of having a single function definition with `if (IS_ENABLED(...))` to make the optimizer include only the appropriate function bodies instead. There are no f