Re: [PATCH 1/3] mmc: s5p_sdhci: remove duplicated card detect code

2025-07-22 Thread Anand Moon
Hi Henrik, On Sun, 20 Jul 2025 at 22:40, Henrik Grimler wrote: > > The common sdhci infrastructure is already parsing the cd-gpios > property, since commit 451931ea7002 ("mmc: sdhci: Read cd-gpio from > devicetree"). The s5p code is therefore duplicated, and also broken > since it assumes that th

Re: [PATCH 1/3] mmc: s5p_sdhci: remove duplicated card detect code

2025-07-21 Thread Sam Protsenko
On Sun, Jul 20, 2025 at 12:00 PM Henrik Grimler wrote: > > The common sdhci infrastructure is already parsing the cd-gpios > property, since commit 451931ea7002 ("mmc: sdhci: Read cd-gpio from > devicetree"). The s5p code is therefore duplicated, and also broken > since it assumes that the GPIO va

[PATCH 1/3] mmc: s5p_sdhci: remove duplicated card detect code

2025-07-20 Thread Henrik Grimler
The common sdhci infrastructure is already parsing the cd-gpios property, since commit 451931ea7002 ("mmc: sdhci: Read cd-gpio from devicetree"). The s5p code is therefore duplicated, and also broken since it assumes that the GPIO value is inverted, while the sdhci code correctly follows the ACTIVE