Re: [PATCH 1/3] gpio: at91: Implement GPIOF_FUNC in get_function()

2024-11-12 Thread Zixun LI
On Tue, Nov 12, 2024 at 4:59 PM Eugen Hristev wrote: > > > > On 11/12/24 17:57, Zixun LI wrote: > > Hello, > > > > > > On Tue, Nov 12, 2024 at 2:13 PM Eugen Hristev > > wrote: > >> > >> > >>> +static bool at91_get_port_pio(struct at91_port *at91_port, int offset) > >> > >> The name get_port_pio

Re: [PATCH 1/3] gpio: at91: Implement GPIOF_FUNC in get_function()

2024-11-12 Thread Zixun LI
Hello, On Tue, Nov 12, 2024 at 2:13 PM Eugen Hristev wrote: > > > > +static bool at91_get_port_pio(struct at91_port *at91_port, int offset) > > The name get_port_pio is a bit confusing, can you rename it to something > more meaningful, like maybe is_periph_func or something ? How about at91_is_

Re: [PATCH 1/3] gpio: at91: Implement GPIOF_FUNC in get_function()

2024-11-12 Thread Eugen Hristev
On 11/12/24 18:17, Zixun LI wrote: > On Tue, Nov 12, 2024 at 4:59 PM Eugen Hristev > wrote: >> >> >> >> On 11/12/24 17:57, Zixun LI wrote: >>> Hello, >>> >>> >>> On Tue, Nov 12, 2024 at 2:13 PM Eugen Hristev >>> wrote: > +static bool at91_get_port_pio(struct at91_port *at91_por

Re: [PATCH 1/3] gpio: at91: Implement GPIOF_FUNC in get_function()

2024-11-12 Thread Eugen Hristev
On 11/12/24 17:57, Zixun LI wrote: > Hello, > > > On Tue, Nov 12, 2024 at 2:13 PM Eugen Hristev > wrote: >> >> >>> +static bool at91_get_port_pio(struct at91_port *at91_port, int offset) >> >> The name get_port_pio is a bit confusing, can you rename it to something >> more meaningful, like m

Re: [PATCH 1/3] gpio: at91: Implement GPIOF_FUNC in get_function()

2024-11-12 Thread Eugen Hristev
Hello, On 10/18/24 23:27, Zixun LI wrote: > This patch adds support for determining whether a gpio pin is mapped as > peripheral function. > > Signed-off-by: Zixun LI > --- > drivers/gpio/at91_gpio.c | 13 - > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/drivers

[PATCH 1/3] gpio: at91: Implement GPIOF_FUNC in get_function()

2024-10-18 Thread Zixun LI
This patch adds support for determining whether a gpio pin is mapped as peripheral function. Signed-off-by: Zixun LI --- drivers/gpio/at91_gpio.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/gpio/at91_gpio.c b/drivers/gpio/at91_gpio.c index 1409db5dc1