Re: [PATCH 1/3] dtoc: Rename is_wider_than() to reduce confusion

Hi Simon, On 11/24/21 21:12, Simon Glass wrote: Hi Walter, On Mon, 2 Aug 2021 at 13:29, Walter Lozano wrote: Hi Simon, On 8/1/21 11:50 PM, Simon Glass wrote: Hi Walter, On Sun, 1 Aug 2021 at 20:45, Walter Lozano wrote: Hi Simon, Thanks for checking this bug, I'm glad that you were able

Re: [PATCH 1/3] dtoc: Rename is_wider_than() to reduce confusion

Hi Walter, On Mon, 2 Aug 2021 at 13:29, Walter Lozano wrote: > > Hi Simon, > > On 8/1/21 11:50 PM, Simon Glass wrote: > > Hi Walter, > > > > On Sun, 1 Aug 2021 at 20:45, Walter Lozano wrote: > >> Hi Simon, > >> > >> Thanks for checking this bug, I'm glad that you were able to come with > >> fix

Re: [PATCH 1/3] dtoc: Rename is_wider_than() to reduce confusion

Hi Simon, On 8/1/21 11:50 PM, Simon Glass wrote: Hi Walter, On Sun, 1 Aug 2021 at 20:45, Walter Lozano wrote: Hi Simon, Thanks for checking this bug, I'm glad that you were able to come with fix quickly. I have some questions, I hope that you find some time to help me understand. On 7/28/21

Re: [PATCH 1/3] dtoc: Rename is_wider_than() to reduce confusion

Hi Walter, On Sun, 1 Aug 2021 at 20:45, Walter Lozano wrote: > > Hi Simon, > > Thanks for checking this bug, I'm glad that you were able to come with > fix quickly. I have some questions, I hope that you find some time to > help me understand. > > On 7/28/21 10:23 PM, Simon Glass wrote: > > The c

Re: [PATCH 1/3] dtoc: Rename is_wider_than() to reduce confusion

Hi Simon, Thanks for checking this bug, I'm glad that you were able to come with fix quickly. I have some questions, I hope that you find some time to help me understand. On 7/28/21 10:23 PM, Simon Glass wrote: The current name is confusing because the logic is actually backwards from what y

Re: [PATCH 1/3] dtoc: Rename is_wider_than() to reduce confusion

The current name is confusing because the logic is actually backwards from what you might expect. Rename it to needs_widening() and update the comments. Signed-off-by: Simon Glass --- tools/dtoc/fdt.py | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) Applied to u-boot-dm,

[PATCH 1/3] dtoc: Rename is_wider_than() to reduce confusion

The current name is confusing because the logic is actually backwards from what you might expect. Rename it to needs_widening() and update the comments. Signed-off-by: Simon Glass --- tools/dtoc/fdt.py | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/tools/dto