Hi Peter,
On Thu, Dec 21, 2023 at 9:13 AM Peter Robinson wrote:
>
> Hi Simon,
>
> > > > > > Hmm I don't know, but I wonder why I am not just checking
> > > > > > t->bios_ver for Unknown.
> > > > > > I'll have a look and change it
> > > > >
> > > > > Ok, this can't be changed as easily. smbios_a
Hi Simon,
> > > > > Hmm I don't know, but I wonder why I am not just checking t->bios_ver
> > > > > for Unknown.
> > > > > I'll have a look and change it
> > > >
> > > > Ok, this can't be changed as easily. smbios_add_prop() will not
> > > > return NULL in any case. It returns an integer. With t
On Wed, Dec 20, 2023 at 10:32:26AM -0700, Simon Glass wrote:
> Hi Peter,
>
> On Tue, 19 Dec 2023 at 13:40, Peter Robinson wrote:
> >
> > Hi Simon,
> >
> > On Mon, Dec 18, 2023 at 3:02 PM Simon Glass wrote:
> > >
> > > Hi Ilias,
> > >
> > > On Wed, 6 Dec 2023 at 04:36, Ilias Apalodimas
> > > wro
Hi Peter,
On Tue, 19 Dec 2023 at 13:40, Peter Robinson wrote:
>
> Hi Simon,
>
> On Mon, Dec 18, 2023 at 3:02 PM Simon Glass wrote:
> >
> > Hi Ilias,
> >
> > On Wed, 6 Dec 2023 at 04:36, Ilias Apalodimas
> > wrote:
> > >
> > > [...]
> > >
> > > >
> > > >>
> > > >> > str = "Unknow
Hi Simon,
The discussion is mostly on v3 now, so I assume this is outdated?
Thanks
/Ilias
On Mon, 18 Dec 2023 at 17:02, Simon Glass wrote:
>
> Hi Ilias,
>
> On Wed, 6 Dec 2023 at 04:36, Ilias Apalodimas
> wrote:
> >
> > [...]
> >
> > >
> > >>
> > >> > str = "Unknown";
> > >> >
>
Hi Simon,
On Mon, Dec 18, 2023 at 3:02 PM Simon Glass wrote:
>
> Hi Ilias,
>
> On Wed, 6 Dec 2023 at 04:36, Ilias Apalodimas
> wrote:
> >
> > [...]
> >
> > >
> > >>
> > >> > str = "Unknown";
> > >> >
> > >> > for (;;) {
> > >> > @@ -151,8 +151,7 @@ static int smbios_add_p
Hi Ilias,
On Wed, 6 Dec 2023 at 04:36, Ilias Apalodimas
wrote:
>
> [...]
>
> >
> >>
> >> > str = "Unknown";
> >> >
> >> > for (;;) {
> >> > @@ -151,8 +151,7 @@ static int smbios_add_prop_si(struct smbios_ctx
> >> > *ctx, const char *prop,
> >> > const char
[...]
>
>>
>> > str = "Unknown";
>> >
>> > for (;;) {
>> > @@ -151,8 +151,7 @@ static int smbios_add_prop_si(struct smbios_ctx *ctx,
>> > const char *prop,
>> > const char *str;
>> >
>> > str = ofnode_read_string(ctx->node, prop);
>> > -
Hi Simon,
On Thu, 30 Nov 2023 at 04:46, Simon Glass wrote:
> Hi Ilias,
>
> On Mon, 27 Nov 2023 at 10:11, Ilias Apalodimas
> wrote:
> >
> > If a value is not valid during the DT or SYSINFO parsing, we explicitly
> > set that to "Unknown Product" and "Unknown" for the product and
> > manufactur
Hi Ilias,
On Mon, 27 Nov 2023 at 10:11, Ilias Apalodimas
wrote:
>
> If a value is not valid during the DT or SYSINFO parsing, we explicitly
> set that to "Unknown Product" and "Unknown" for the product and
> manufacturer respectively. It's cleaner if we move the checks insisde
> smbios_add_stri
On Mon, Nov 27, 2023 at 07:10:57PM +0200, Ilias Apalodimas wrote:
> If a value is not valid during the DT or SYSINFO parsing, we explicitly
> set that to "Unknown Product" and "Unknown" for the product and
> manufacturer respectively. It's cleaner if we move the checks insisde
> smbios_add_strin
If a value is not valid during the DT or SYSINFO parsing, we explicitly
set that to "Unknown Product" and "Unknown" for the product and
manufacturer respectively. It's cleaner if we move the checks insisde
smbios_add_string() and always report "Unknown" regardless of the missing
field.
pre-patch
12 matches
Mail list logo
