Re: [PATCH 1/2] spl: Avoid printing boot device if silent console is enabled

2020-10-01 Thread Stefan Roese
On 30.09.20 13:47, Otavio Salvador wrote: Em qua., 30 de set. de 2020 às 02:23, Stefan Roese escreveu: On 30.09.20 04:14, Otavio Salvador wrote: Wouldn't it be better, to add this CONFIG_SILENT_CONSOLE check to the console / printf function itself instead of adding it to all callers? I believ

Re: [PATCH 1/2] spl: Avoid printing boot device if silent console is enabled

2020-09-30 Thread Otavio Salvador
Em qua., 30 de set. de 2020 às 02:23, Stefan Roese escreveu: > On 30.09.20 04:14, Otavio Salvador wrote: > Wouldn't it be better, to add this CONFIG_SILENT_CONSOLE check to > the console / printf function itself instead of adding it to all > callers? I believe in critical errors and like, it is i

Re: [PATCH 1/2] spl: Avoid printing boot device if silent console is enabled

2020-09-29 Thread Stefan Roese
Hi Otavio, On 30.09.20 04:14, Otavio Salvador wrote: This avoid emitting message if silent console is in use, otherwise it pollutes the output and user desires a quiet console Signed-off-by: Otavio Salvador --- common/spl/spl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff

[PATCH 1/2] spl: Avoid printing boot device if silent console is enabled

2020-09-29 Thread Otavio Salvador
This avoid emitting message if silent console is in use, otherwise it pollutes the output and user desires a quiet console Signed-off-by: Otavio Salvador --- common/spl/spl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/common/spl/spl.c b/common/spl/spl.c index 4840d1d