Re: [PATCH 1/1] sandbox: don't call os_close with invalid file descriptor

2024-04-17 Thread Tom Rini
On Wed, 10 Apr 2024 23:50:34 +0200, Heinrich Schuchardt wrote: > If open() fails it returns -1. Calling close() with this value > makes no sense. Return -EIO instead. > > Applied to u-boot/master, thanks! -- Tom

Re: [PATCH 1/1] sandbox: don't call os_close with invalid file descriptor

2024-04-10 Thread Sean Anderson
On 4/10/24 17:50, Heinrich Schuchardt wrote: If open() fails it returns -1. Calling close() with this value makes no sense. Return -EIO instead. Addresses-Coverity-ID: 185828 Improper use of negative value Signed-off-by: Heinrich Schuchardt --- arch/sandbox/cpu/os.c | 2 +- 1 file changed, 1

[PATCH 1/1] sandbox: don't call os_close with invalid file descriptor

2024-04-10 Thread Heinrich Schuchardt
If open() fails it returns -1. Calling close() with this value makes no sense. Return -EIO instead. Addresses-Coverity-ID: 185828 Improper use of negative value Signed-off-by: Heinrich Schuchardt --- arch/sandbox/cpu/os.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/s