Re: [PATCH 1/1] lib: missing fallthrough comment in vsnprintf_internal()

On Sat, Apr 01, 2023 at 08:13:42AM +0200, Heinrich Schuchardt wrote: > When a case statement intentionally falls through we should add a comment. > Cf. -Wimplicit-fallthrough > > Signed-off-by: Heinrich Schuchardt Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signa

Re: [PATCH 1/1] lib: missing fallthrough comment in vsnprintf_internal()

Hi Heinrich, On Sat, 1 Apr 2023 at 19:13, Heinrich Schuchardt < heinrich.schucha...@canonical.com> wrote: > > When a case statement intentionally falls through we should add a comment. > Cf. -Wimplicit-fallthrough > > Signed-off-by: Heinrich Schuchardt > --- > lib/vsprintf.c | 4 > 1 file c

[PATCH 1/1] lib: missing fallthrough comment in vsnprintf_internal()

When a case statement intentionally falls through we should add a comment. Cf. -Wimplicit-fallthrough Signed-off-by: Heinrich Schuchardt --- lib/vsprintf.c | 4 1 file changed, 4 insertions(+) diff --git a/lib/vsprintf.c b/lib/vsprintf.c index 2d13e68b57..8af6310651 100644 --- a/lib/vsprin