Re: [PATCH 1/1] efi_loader: fix efi_initrd_deregister()

2022-09-30 Thread Ilias Apalodimas
On Fri, 30 Sept 2022 at 10:55, Heinrich Schuchardt wrote: > > On 9/30/22 09:29, Ilias Apalodimas wrote: > > Hi Heinrich > > > > On Fri, 30 Sept 2022 at 10:18, Heinrich Schuchardt > > wrote: > >> > >> On 9/30/22 08:54, Ilias Apalodimas wrote: > >>> Akashi-san > >>> > >>> On Fri, 30 Sept 2022 at 09

Re: [PATCH 1/1] efi_loader: fix efi_initrd_deregister()

2022-09-30 Thread Heinrich Schuchardt
On 9/30/22 09:29, Ilias Apalodimas wrote: Hi Heinrich On Fri, 30 Sept 2022 at 10:18, Heinrich Schuchardt wrote: On 9/30/22 08:54, Ilias Apalodimas wrote: Akashi-san On Fri, 30 Sept 2022 at 09:41, AKASHI Takahiro wrote: Ilias, On Fri, Sep 30, 2022 at 09:18:35AM +0300, Ilias Apalodimas wr

Re: [PATCH 1/1] efi_loader: fix efi_initrd_deregister()

2022-09-30 Thread Ilias Apalodimas
Hi Heinrich On Fri, 30 Sept 2022 at 10:18, Heinrich Schuchardt wrote: > > On 9/30/22 08:54, Ilias Apalodimas wrote: > > Akashi-san > > > > On Fri, 30 Sept 2022 at 09:41, AKASHI Takahiro > > wrote: > >> > >> Ilias, > >> > >> On Fri, Sep 30, 2022 at 09:18:35AM +0300, Ilias Apalodimas wrote: > >>>

Re: [PATCH 1/1] efi_loader: fix efi_initrd_deregister()

2022-09-30 Thread Heinrich Schuchardt
On 9/30/22 08:54, Ilias Apalodimas wrote: Akashi-san On Fri, 30 Sept 2022 at 09:41, AKASHI Takahiro wrote: Ilias, On Fri, Sep 30, 2022 at 09:18:35AM +0300, Ilias Apalodimas wrote: Akashi-san On Fri, 30 Sept 2022 at 04:47, AKASHI Takahiro wrote: On Fri, Sep 30, 2022 at 01:57:48AM +0200,

Re: [PATCH 1/1] efi_loader: fix efi_initrd_deregister()

2022-09-29 Thread Ilias Apalodimas
Akashi-san On Fri, 30 Sept 2022 at 09:41, AKASHI Takahiro wrote: > > Ilias, > > On Fri, Sep 30, 2022 at 09:18:35AM +0300, Ilias Apalodimas wrote: > > Akashi-san > > > > On Fri, 30 Sept 2022 at 04:47, AKASHI Takahiro > > wrote: > > > > > > On Fri, Sep 30, 2022 at 01:57:48AM +0200, Heinrich Schuch

Re: [PATCH 1/1] efi_loader: fix efi_initrd_deregister()

2022-09-29 Thread AKASHI Takahiro
Ilias, On Fri, Sep 30, 2022 at 09:18:35AM +0300, Ilias Apalodimas wrote: > Akashi-san > > On Fri, 30 Sept 2022 at 04:47, AKASHI Takahiro > wrote: > > > > On Fri, Sep 30, 2022 at 01:57:48AM +0200, Heinrich Schuchardt wrote: > > > Don't try to delete a non-existent handle. > > > > It is okay as a

Re: [PATCH 1/1] efi_loader: fix efi_initrd_deregister()

2022-09-29 Thread Ilias Apalodimas
Akashi-san On Fri, 30 Sept 2022 at 04:47, AKASHI Takahiro wrote: > > On Fri, Sep 30, 2022 at 01:57:48AM +0200, Heinrich Schuchardt wrote: > > Don't try to delete a non-existent handle. > > It is okay as a safe guard, but it doesn't fix underlying issues. I dont think we safeguard anything. That

Re: [PATCH 1/1] efi_loader: fix efi_initrd_deregister()

2022-09-29 Thread Ilias Apalodimas
Hi Heinrich On Fri, 30 Sept 2022 at 02:58, Heinrich Schuchardt wrote: > > Don't try to delete a non-existent handle. > > Signed-off-by: Heinrich Schuchardt > --- > lib/efi_loader/efi_load_initrd.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/lib/efi_loader/efi_load_initrd.c > b/

Re: [PATCH 1/1] efi_loader: fix efi_initrd_deregister()

2022-09-29 Thread AKASHI Takahiro
On Fri, Sep 30, 2022 at 01:57:48AM +0200, Heinrich Schuchardt wrote: > Don't try to delete a non-existent handle. It is okay as a safe guard, but it doesn't fix underlying issues. efi_initrd_register() is called only in efi_bootmgr_load(), and so efi_initrd_deregister() should be called only at t

[PATCH 1/1] efi_loader: fix efi_initrd_deregister()

2022-09-29 Thread Heinrich Schuchardt
Don't try to delete a non-existent handle. Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/efi_load_initrd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/efi_loader/efi_load_initrd.c b/lib/efi_loader/efi_load_initrd.c index c5e6652e66..3d6044f760 100644 --- a/lib/efi_loader/e