Re: [PATCH 08/35] common: Move relocate_code() to init.h

2019-12-11 Thread Timur Tabi (ti...@kernel.org)
On 12/11/19 6:47 PM, Simon Glass wrote: - * void relocate_code (addr_moni) + * void relocate_code(addr_moni) Is this really necessary? I think you're bloating your patch with these comment changes. Your patch would be half the size without these changes, so I don't think this really qualifi

[PATCH 08/35] common: Move relocate_code() to init.h

2019-12-11 Thread Simon Glass
This is an init function so move it out of the common header. Avoid using the typedef so that we don't have to include the global_data header file. Also tidy up the function style in comments while we are here. Signed-off-by: Simon Glass --- arch/arm/lib/relocate_64.S | 2 +-