Re: [PATCH 07/18] rockchip: pine64: pinephone: migrate to rockchip_early_misc_init_r

2024-02-03 Thread Dragan Simic
Hello Quentin, Please see my comments below. On 2024-01-23 15:49, Quentin Schulz wrote: From: Quentin Schulz Compared to the original misc_init_r from Rockchip mach code, setup_iodomain() is added and rockchip_setup_macaddr() is not called. It is assumed adding rockchip_setup_macaddr() back

Re: [PATCH 07/18] rockchip: pine64: pinephone: migrate to rockchip_early_misc_init_r

2024-01-31 Thread Kever Yang
On 2024/1/23 22:49, Quentin Schulz wrote: From: Quentin Schulz Compared to the original misc_init_r from Rockchip mach code, setup_iodomain() is added and rockchip_setup_macaddr() is not called. It is assumed adding rockchip_setup_macaddr() back is fine. Let's use rockchip_early_misc_init_r

[PATCH 07/18] rockchip: pine64: pinephone: migrate to rockchip_early_misc_init_r

2024-01-23 Thread Quentin Schulz
From: Quentin Schulz Compared to the original misc_init_r from Rockchip mach code, setup_iodomain() is added and rockchip_setup_macaddr() is not called. It is assumed adding rockchip_setup_macaddr() back is fine. Let's use rockchip_early_misc_init_r instead of reimplementing the whole misc_init_