Re: [PATCH 06/19] aspeed: ast2500: Read clock ofdata in the correct method

2020-01-10 Thread sjg
Hi Cédric, On Tue, 7 Jan 2020 at 21:20, Cédric Le Goater wrote: > > On 12/30/19 5:19 AM, Simon Glass wrote: > > At present the clock driver reads its ofdata in the probe() method. This > > is not correct although it is often harmless. > > > > However in this case it causes a problem, something li

Re: [PATCH 06/19] aspeed: ast2500: Read clock ofdata in the correct method

2020-01-09 Thread Simon Glass
Hi Cédric, On Tue, 7 Jan 2020 at 21:20, Cédric Le Goater wrote: > > On 12/30/19 5:19 AM, Simon Glass wrote: > > At present the clock driver reads its ofdata in the probe() method. This > > is not correct although it is often harmless. > > > > However in this case it causes a problem, something li

Re: [PATCH 06/19] aspeed: ast2500: Read clock ofdata in the correct method

2020-01-07 Thread Cédric Le Goater
On 12/30/19 5:19 AM, Simon Glass wrote: > At present the clock driver reads its ofdata in the probe() method. This > is not correct although it is often harmless. > > However in this case it causes a problem, something like this: > > - ast_get_scu() is called (from somewhere) to get the SCI addre

[PATCH 06/19] aspeed: ast2500: Read clock ofdata in the correct method

2019-12-29 Thread Simon Glass
At present the clock driver reads its ofdata in the probe() method. This is not correct although it is often harmless. However in this case it causes a problem, something like this: - ast_get_scu() is called (from somewhere) to get the SCI address - this probes the clock - first sets up ofdata