Re: [PATCH 06/18] rockchip: pine64: pinebook: migrate to rockchip_early_misc_init_r

2024-02-03 Thread Dragan Simic
Hello Quentin and Kever, Please see my comments below. On 2024-02-01 05:02, Dragan Simic wrote: On 2024-02-01 03:48, Kever Yang wrote: On 2024/1/23 22:49, Quentin Schulz wrote: From: Quentin Schulz Compared to the original misc_init_r from Rockchip mach code, setup_iodomain() is added and r

Re: [PATCH 06/18] rockchip: pine64: pinebook: migrate to rockchip_early_misc_init_r

2024-02-01 Thread Dragan Simic
Hello Quentin, On 2024-02-01 18:46, Quentin Schulz wrote: On 2/1/24 05:02, Dragan Simic wrote: On 2024-02-01 03:48, Kever Yang wrote: On 2024/1/23 22:49, Quentin Schulz wrote: From: Quentin Schulz Compared to the original misc_init_r from Rockchip mach code, setup_iodomain() is added and ro

Re: [PATCH 06/18] rockchip: pine64: pinebook: migrate to rockchip_early_misc_init_r

2024-02-01 Thread Quentin Schulz
Hi Dragan, On 2/1/24 05:02, Dragan Simic wrote: [Some people who received this message don't often get email from dsi...@manjaro.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] Hello Kever and Quentin, On 2024-02-01 03:48, Kever Yang wrote: On 2024/1/23 2

Re: [PATCH 06/18] rockchip: pine64: pinebook: migrate to rockchip_early_misc_init_r

2024-01-31 Thread Dragan Simic
Hello Kever and Quentin, On 2024-02-01 03:48, Kever Yang wrote: On 2024/1/23 22:49, Quentin Schulz wrote: From: Quentin Schulz Compared to the original misc_init_r from Rockchip mach code, setup_iodomain() is added and rockchip_setup_macaddr() is not called. It is assumed adding rockchip_set

Re: [PATCH 06/18] rockchip: pine64: pinebook: migrate to rockchip_early_misc_init_r

2024-01-31 Thread Kever Yang
On 2024/1/23 22:49, Quentin Schulz wrote: From: Quentin Schulz Compared to the original misc_init_r from Rockchip mach code, setup_iodomain() is added and rockchip_setup_macaddr() is not called. It is assumed adding rockchip_setup_macaddr() back is fine. Let's use rockchip_early_misc_init_r

[PATCH 06/18] rockchip: pine64: pinebook: migrate to rockchip_early_misc_init_r

2024-01-23 Thread Quentin Schulz
From: Quentin Schulz Compared to the original misc_init_r from Rockchip mach code, setup_iodomain() is added and rockchip_setup_macaddr() is not called. It is assumed adding rockchip_setup_macaddr() back is fine. Let's use rockchip_early_misc_init_r instead of reimplementing the whole misc_init_