Re: [PATCH 05/13] efi_loader: Move some memory-function comments to header

2024-12-03 Thread Simon Glass
Hi Tom, On Mon, 2 Dec 2024 at 17:35, Tom Rini wrote: > > On Mon, Dec 02, 2024 at 05:20:31PM -0700, Simon Glass wrote: > > Hi Tom, > > > > On Mon, 2 Dec 2024 at 06:35, Tom Rini wrote: > > > > > > On Sat, Nov 30, 2024 at 01:24:54PM -0700, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On Wed,

Re: [PATCH 05/13] efi_loader: Move some memory-function comments to header

2024-12-02 Thread Tom Rini
On Mon, Dec 02, 2024 at 05:20:31PM -0700, Simon Glass wrote: > Hi Tom, > > On Mon, 2 Dec 2024 at 06:35, Tom Rini wrote: > > > > On Sat, Nov 30, 2024 at 01:24:54PM -0700, Simon Glass wrote: > > > Hi Tom, > > > > > > On Wed, 27 Nov 2024 at 15:11, Tom Rini wrote: > > > > > > > > On Wed, Nov 27, 202

Re: [PATCH 05/13] efi_loader: Move some memory-function comments to header

2024-12-02 Thread Simon Glass
Hi Tom, On Mon, 2 Dec 2024 at 06:35, Tom Rini wrote: > > On Sat, Nov 30, 2024 at 01:24:54PM -0700, Simon Glass wrote: > > Hi Tom, > > > > On Wed, 27 Nov 2024 at 15:11, Tom Rini wrote: > > > > > > On Wed, Nov 27, 2024 at 07:56:11AM -0700, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On Wed,

Re: [PATCH 05/13] efi_loader: Move some memory-function comments to header

2024-12-02 Thread Tom Rini
On Sat, Nov 30, 2024 at 01:24:54PM -0700, Simon Glass wrote: > Hi Tom, > > On Wed, 27 Nov 2024 at 15:11, Tom Rini wrote: > > > > On Wed, Nov 27, 2024 at 07:56:11AM -0700, Simon Glass wrote: > > > Hi Tom, > > > > > > On Wed, 27 Nov 2024 at 07:15, Tom Rini wrote: > > > > > > > > On Wed, Nov 27, 20

Re: [PATCH 05/13] efi_loader: Move some memory-function comments to header

2024-11-30 Thread Simon Glass
Hi Tom, On Wed, 27 Nov 2024 at 15:11, Tom Rini wrote: > > On Wed, Nov 27, 2024 at 07:56:11AM -0700, Simon Glass wrote: > > Hi Tom, > > > > On Wed, 27 Nov 2024 at 07:15, Tom Rini wrote: > > > > > > On Wed, Nov 27, 2024 at 06:07:58AM -0700, Simon Glass wrote: > > > > Hi, > > > > > > > > On Tue, 26

Re: [PATCH 05/13] efi_loader: Move some memory-function comments to header

2024-11-27 Thread Tom Rini
On Wed, Nov 27, 2024 at 07:56:11AM -0700, Simon Glass wrote: > Hi Tom, > > On Wed, 27 Nov 2024 at 07:15, Tom Rini wrote: > > > > On Wed, Nov 27, 2024 at 06:07:58AM -0700, Simon Glass wrote: > > > Hi, > > > > > > On Tue, 26 Nov 2024 at 16:32, Tom Rini wrote: > > > > > > > > On Tue, Nov 26, 2024 a

Re: [PATCH 05/13] efi_loader: Move some memory-function comments to header

2024-11-27 Thread Simon Glass
Hi Tom, On Wed, 27 Nov 2024 at 07:15, Tom Rini wrote: > > On Wed, Nov 27, 2024 at 06:07:58AM -0700, Simon Glass wrote: > > Hi, > > > > On Tue, 26 Nov 2024 at 16:32, Tom Rini wrote: > > > > > > On Tue, Nov 26, 2024 at 11:50:40PM +0100, Heinrich Schuchardt wrote: > > > > On 11/26/24 23:33, Tom Rin

Re: [PATCH 05/13] efi_loader: Move some memory-function comments to header

2024-11-27 Thread Tom Rini
On Wed, Nov 27, 2024 at 06:07:58AM -0700, Simon Glass wrote: > Hi, > > On Tue, 26 Nov 2024 at 16:32, Tom Rini wrote: > > > > On Tue, Nov 26, 2024 at 11:50:40PM +0100, Heinrich Schuchardt wrote: > > > On 11/26/24 23:33, Tom Rini wrote: > > > > On Tue, Nov 26, 2024 at 01:04:25PM -0700, Simon Glass

Re: [PATCH 05/13] efi_loader: Move some memory-function comments to header

2024-11-27 Thread Simon Glass
Hi, On Tue, 26 Nov 2024 at 16:32, Tom Rini wrote: > > On Tue, Nov 26, 2024 at 11:50:40PM +0100, Heinrich Schuchardt wrote: > > On 11/26/24 23:33, Tom Rini wrote: > > > On Tue, Nov 26, 2024 at 01:04:25PM -0700, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On Tue, 26 Nov 2024 at 08:55, Tom Ri

Re: [PATCH 05/13] efi_loader: Move some memory-function comments to header

2024-11-26 Thread Tom Rini
On Tue, Nov 26, 2024 at 11:50:40PM +0100, Heinrich Schuchardt wrote: > On 11/26/24 23:33, Tom Rini wrote: > > On Tue, Nov 26, 2024 at 01:04:25PM -0700, Simon Glass wrote: > > > Hi Tom, > > > > > > On Tue, 26 Nov 2024 at 08:55, Tom Rini wrote: > > > > > > > > On Tue, Nov 26, 2024 at 08:37:33AM -0

Re: [PATCH 05/13] efi_loader: Move some memory-function comments to header

2024-11-26 Thread Heinrich Schuchardt
On 11/26/24 23:33, Tom Rini wrote: On Tue, Nov 26, 2024 at 01:04:25PM -0700, Simon Glass wrote: Hi Tom, On Tue, 26 Nov 2024 at 08:55, Tom Rini wrote: On Tue, Nov 26, 2024 at 08:37:33AM -0700, Simon Glass wrote: Hi Heinrich, On Tue, 26 Nov 2024 at 02:35, Heinrich Schuchardt wrote: On 25.

Re: [PATCH 05/13] efi_loader: Move some memory-function comments to header

2024-11-26 Thread Tom Rini
On Tue, Nov 26, 2024 at 01:04:25PM -0700, Simon Glass wrote: > Hi Tom, > > On Tue, 26 Nov 2024 at 08:55, Tom Rini wrote: > > > > On Tue, Nov 26, 2024 at 08:37:33AM -0700, Simon Glass wrote: > > > Hi Heinrich, > > > > > > On Tue, 26 Nov 2024 at 02:35, Heinrich Schuchardt > > > wrote: > > > > > >

Re: [PATCH 05/13] efi_loader: Move some memory-function comments to header

2024-11-26 Thread Simon Glass
Hi Tom, On Tue, 26 Nov 2024 at 08:55, Tom Rini wrote: > > On Tue, Nov 26, 2024 at 08:37:33AM -0700, Simon Glass wrote: > > Hi Heinrich, > > > > On Tue, 26 Nov 2024 at 02:35, Heinrich Schuchardt > > wrote: > > > > > > On 25.11.24 21:44, Simon Glass wrote: > > > > Exported functions should be doc

Re: [PATCH 05/13] efi_loader: Move some memory-function comments to header

2024-11-26 Thread Tom Rini
On Tue, Nov 26, 2024 at 08:37:33AM -0700, Simon Glass wrote: > Hi Heinrich, > > On Tue, 26 Nov 2024 at 02:35, Heinrich Schuchardt wrote: > > > > On 25.11.24 21:44, Simon Glass wrote: > > > Exported functions should be documented in the header file, not the > > > implementation. We tend to make su

Re: [PATCH 05/13] efi_loader: Move some memory-function comments to header

2024-11-26 Thread Simon Glass
Hi Heinrich, On Tue, 26 Nov 2024 at 02:35, Heinrich Schuchardt wrote: > > On 25.11.24 21:44, Simon Glass wrote: > > Exported functions should be documented in the header file, not the > > implementation. We tend to make such updates on a piecemeal basis to > > avoid a 'flag day'. Move some commen

Re: [PATCH 05/13] efi_loader: Move some memory-function comments to header

2024-11-26 Thread Heinrich Schuchardt
On 25.11.24 21:44, Simon Glass wrote: Exported functions should be documented in the header file, not the implementation. We tend to make such updates on a piecemeal basis to avoid a 'flag day'. Move some comments related to memory allocation to follow the convention. Signed-off-by: Simon Glass

[PATCH 05/13] efi_loader: Move some memory-function comments to header

2024-11-25 Thread Simon Glass
Exported functions should be documented in the header file, not the implementation. We tend to make such updates on a piecemeal basis to avoid a 'flag day'. Move some comments related to memory allocation to follow the convention. Signed-off-by: Simon Glass --- include/efi_loader.h| 70