RE: [Uboot-stm32] [PATCH 04/16] arm: stm32mp: detect U-Boot version used to save environment

2020-04-08 Thread Patrick DELAUNAY
Dear Wolfgang, > From: Uboot-stm32 On > Behalf Of Wolfgang Denk > > Dear Patrick, > > In message <8607d1778bcd4035807908e4a3a90...@sfhdag6node3.st.com> > you wrote: > > > > To simplify the test: > > > > env_check = " if env info -p -d -q; then env save; fi;" > > All such automatical "env save"

Re: [PATCH 04/16] arm: stm32mp: detect U-Boot version used to save environment

2020-04-07 Thread Wolfgang Denk
Dear Patrick, In message <8607d1778bcd4035807908e4a3a90...@sfhdag6node3.st.com> you wrote: > > To simplify the test: > > env_check = " if env info -p -d -q; then env save; fi;" All such automatical "env save" actions somewhere in the code give me the creeps. I've seen too often that they did t

RE: [PATCH 04/16] arm: stm32mp: detect U-Boot version used to save environment

2020-04-07 Thread Patrick DELAUNAY
Dear Wolfgang, > From: Wolfgang Denk > Sent: mercredi 1 avril 2020 13:26 > > Dear Patrick Delaunay, > > In message <20200331160456.26254-1-patrick.delau...@st.com> you wrote: > > Imply CONFIG_VERSION_VARIABLE for stm32mp1 target and test U-Boot > > version ($env_ver) when the environment was sa

RE: [PATCH 04/16] arm: stm32mp: detect U-Boot version used to save environment

2020-04-07 Thread Patrick DELAUNAY
Hi Patrice > From: Patrice CHOTARD > Sent: mercredi 1 avril 2020 09:34 > > Hi Patrick > > On 3/31/20 6:04 PM, Patrick Delaunay wrote: > > Imply CONFIG_VERSION_VARIABLE for stm32mp1 target and test U-Boot > > version ($env_ver) when the environment was saved for the last time > > and to display

Re: [PATCH 04/16] arm: stm32mp: detect U-Boot version used to save environment

2020-04-01 Thread Wolfgang Denk
Dear Patrick Delaunay, In message <20200331160456.26254-1-patrick.delau...@st.com> you wrote: > Imply CONFIG_VERSION_VARIABLE for stm32mp1 target > and test U-Boot version ($env_ver) when the environment was > saved for the last time and to display warning trace. What is env_ver? Are you by chan

Re: [PATCH 04/16] arm: stm32mp: detect U-Boot version used to save environment

2020-04-01 Thread Patrice CHOTARD
Hi Patrick On 3/31/20 6:04 PM, Patrick Delaunay wrote: > Imply CONFIG_VERSION_VARIABLE for stm32mp1 target > and test U-Boot version ($env_ver) when the environment was > saved for the last time and to display warning trace. > > Signed-off-by: Patrick Delaunay > --- > > arch/arm/mach-stm32mp/Kco

[PATCH 04/16] arm: stm32mp: detect U-Boot version used to save environment

2020-03-31 Thread Patrick Delaunay
Imply CONFIG_VERSION_VARIABLE for stm32mp1 target and test U-Boot version ($env_ver) when the environment was saved for the last time and to display warning trace. Signed-off-by: Patrick Delaunay --- arch/arm/mach-stm32mp/Kconfig | 1 + include/configs/stm32mp1.h| 11 --- 2 files c