Re: [PATCH 02/31] kconfig: Add support for conditional values

2022-01-13 Thread Tom Rini
On Thu, Jan 13, 2022 at 04:01:45PM +0100, Rasmus Villemoes wrote: > On 13/01/2022 13.52, Tom Rini wrote: > > On Thu, Jan 13, 2022 at 08:56:02AM +0100, Rasmus Villemoes wrote: > >> On 12/01/2022 22.56, Tom Rini wrote: > >>> I also think I've seen cases where doing: > >>> if (CONFIG_EVALUATES_TO_ZERO

Re: [PATCH 02/31] kconfig: Add support for conditional values

2022-01-13 Thread Rasmus Villemoes
On 13/01/2022 13.52, Tom Rini wrote: > On Thu, Jan 13, 2022 at 08:56:02AM +0100, Rasmus Villemoes wrote: >> On 12/01/2022 22.56, Tom Rini wrote: >>> I also think I've seen cases where doing: >>> if (CONFIG_EVALUATES_TO_ZERO) { >>> ... >>> } >>> >>> takes more space in the binary than an #ifdef do

Re: [PATCH 02/31] kconfig: Add support for conditional values

2022-01-13 Thread Simon Glass
Hi, On Thu, 13 Jan 2022 at 05:52, Tom Rini wrote: > > On Thu, Jan 13, 2022 at 08:56:02AM +0100, Rasmus Villemoes wrote: > > On 12/01/2022 22.56, Tom Rini wrote: > > > On Wed, Jan 12, 2022 at 02:28:21PM -0700, Simon Glass wrote: > > >> Hi Ilias, > > >> > > >> On Mon, 1 Nov 2021 at 01:05, Ilias Apa

Re: [PATCH 02/31] kconfig: Add support for conditional values

2022-01-13 Thread Tom Rini
On Thu, Jan 13, 2022 at 08:56:02AM +0100, Rasmus Villemoes wrote: > On 12/01/2022 22.56, Tom Rini wrote: > > On Wed, Jan 12, 2022 at 02:28:21PM -0700, Simon Glass wrote: > >> Hi Ilias, > >> > >> On Mon, 1 Nov 2021 at 01:05, Ilias Apalodimas > >> wrote: > >>> > >>> On Mon, 1 Nov 2021 at 03:19, Simo

Re: [PATCH 02/31] kconfig: Add support for conditional values

2022-01-12 Thread Rasmus Villemoes
On 12/01/2022 22.56, Tom Rini wrote: > On Wed, Jan 12, 2022 at 02:28:21PM -0700, Simon Glass wrote: >> Hi Ilias, >> >> On Mon, 1 Nov 2021 at 01:05, Ilias Apalodimas >> wrote: >>> >>> On Mon, 1 Nov 2021 at 03:19, Simon Glass wrote: At present if an optional Kconfig value needs to be used

Re: [PATCH 02/31] kconfig: Add support for conditional values

2022-01-12 Thread Tom Rini
On Wed, Jan 12, 2022 at 03:22:51PM -0700, Simon Glass wrote: > Hi Tom, > > On Wed, 12 Jan 2022 at 14:56, Tom Rini wrote: > > > > On Wed, Jan 12, 2022 at 02:28:21PM -0700, Simon Glass wrote: > > > Hi Ilias, > > > > > > On Mon, 1 Nov 2021 at 01:05, Ilias Apalodimas > > > wrote: > > > > > > > > On

Re: [PATCH 02/31] kconfig: Add support for conditional values

2022-01-12 Thread Simon Glass
Hi Tom, On Wed, 12 Jan 2022 at 14:56, Tom Rini wrote: > > On Wed, Jan 12, 2022 at 02:28:21PM -0700, Simon Glass wrote: > > Hi Ilias, > > > > On Mon, 1 Nov 2021 at 01:05, Ilias Apalodimas > > wrote: > > > > > > On Mon, 1 Nov 2021 at 03:19, Simon Glass wrote: > > > > > > > > At present if an opti

Re: [PATCH 02/31] kconfig: Add support for conditional values

2022-01-12 Thread Tom Rini
On Wed, Jan 12, 2022 at 02:28:21PM -0700, Simon Glass wrote: > Hi Ilias, > > On Mon, 1 Nov 2021 at 01:05, Ilias Apalodimas > wrote: > > > > On Mon, 1 Nov 2021 at 03:19, Simon Glass wrote: > > > > > > At present if an optional Kconfig value needs to be used it must be > > > bracketed by #ifdef. F

Re: [PATCH 02/31] kconfig: Add support for conditional values

2022-01-12 Thread Simon Glass
Hi Ilias, On Mon, 1 Nov 2021 at 01:05, Ilias Apalodimas wrote: > > On Mon, 1 Nov 2021 at 03:19, Simon Glass wrote: > > > > At present if an optional Kconfig value needs to be used it must be > > bracketed by #ifdef. For example, with this Kconfig setup: > > > > config WIBBLE > > bool "Su

Re: [PATCH 02/31] kconfig: Add support for conditional values

2021-11-01 Thread Ilias Apalodimas
On Mon, 1 Nov 2021 at 03:19, Simon Glass wrote: > > At present if an optional Kconfig value needs to be used it must be > bracketed by #ifdef. For example, with this Kconfig setup: > > config WIBBLE > bool "Support wibbles, the world needs more wibbles" > > config WIBBLE_ADDR > hex

[PATCH 02/31] kconfig: Add support for conditional values

2021-10-31 Thread Simon Glass
At present if an optional Kconfig value needs to be used it must be bracketed by #ifdef. For example, with this Kconfig setup: config WIBBLE bool "Support wibbles, the world needs more wibbles" config WIBBLE_ADDR hex "Address of the wibble" depends on WIBBLE then the foll