Re: [PATCH 02/26] spl: nor: Don't allocate header on stack

2023-10-12 Thread Michael Nazzareno Trimarchi
On Thu, Oct 12, 2023 at 5:45 AM Simon Glass wrote: > > On Wed, 11 Oct 2023 at 18:56, Sean Anderson wrote: > > > > spl_image_info.name contains a reference to legacy_img_hdr. If we allocate > > the latter on the stack, it will be clobbered after we return. This was > > addressed for NAND back in 0

Re: [PATCH 02/26] spl: nor: Don't allocate header on stack

2023-10-11 Thread Simon Glass
On Wed, 11 Oct 2023 at 18:56, Sean Anderson wrote: > > spl_image_info.name contains a reference to legacy_img_hdr. If we allocate > the latter on the stack, it will be clobbered after we return. This was > addressed for NAND back in 06377c5a1fc ("spl: spl_legacy: Fix NAND boot on > OMAP3 BeagleBoa

[PATCH 02/26] spl: nor: Don't allocate header on stack

2023-10-11 Thread Sean Anderson
spl_image_info.name contains a reference to legacy_img_hdr. If we allocate the latter on the stack, it will be clobbered after we return. This was addressed for NAND back in 06377c5a1fc ("spl: spl_legacy: Fix NAND boot on OMAP3 BeagleBoard"), but that commit didn't fix NOR. Signed-off-by: Sean And