Re: [PATCH 02/15] dm: gpio: Rename set_dir_flags() method to update_flags()

2021-01-21 Thread Patrick DELAUNAY
Hi Simon, On 1/15/21 3:04 PM, Simon Glass wrote: The current method is a misnomer since it is also used (e.g. by stm32) to update pull settings and open source/open drain. Rename it and expand the documentation to cover a few more details. Signed-off-by: Simon Glass --- drivers/gpio/gpio-u

Re: [PATCH 02/15] dm: gpio: Rename set_dir_flags() method to update_flags()

2021-01-18 Thread Pratyush Yadav
Hi Simon, > Subject: [PATCH 02/15] dm: gpio: Rename set_dir_flags() method to > update_flags() Why not call it set_flags()? Matches up nicely with get_flags() in 03/15. On 15/01/21 07:04AM, Simon Glass wrote: > The current method is a misnomer since it is also used (e.g. by stm32) to

[PATCH 02/15] dm: gpio: Rename set_dir_flags() method to update_flags()

2021-01-15 Thread Simon Glass
The current method is a misnomer since it is also used (e.g. by stm32) to update pull settings and open source/open drain. Rename it and expand the documentation to cover a few more details. Signed-off-by: Simon Glass --- drivers/gpio/gpio-uclass.c | 16 drivers/gpio/sand