Re: [PATCH 02/14] lmb: Use CONFIG_LMB_*_REGIONS only if they are defined

2021-09-04 Thread Tom Rini
On Sat, Sep 04, 2021 at 09:37:39PM +0200, Marek Vasut wrote: > On 9/4/21 7:01 PM, Tom Rini wrote: > > [trimming the CC list] > > > > On Sat, Sep 04, 2021 at 06:49:03PM +0200, Marek Vasut wrote: > > > On 9/4/21 6:09 PM, Tom Rini wrote: > > > > On Sat, Sep 04, 2021 at 06:05:50PM +0200, Marek Vasut w

Re: [PATCH 02/14] lmb: Use CONFIG_LMB_*_REGIONS only if they are defined

2021-09-04 Thread Marek Vasut
On 9/4/21 7:01 PM, Tom Rini wrote: [trimming the CC list] On Sat, Sep 04, 2021 at 06:49:03PM +0200, Marek Vasut wrote: On 9/4/21 6:09 PM, Tom Rini wrote: On Sat, Sep 04, 2021 at 06:05:50PM +0200, Marek Vasut wrote: On 9/4/21 5:17 PM, Tom Rini wrote: On Sat, Sep 04, 2021 at 05:15:45PM +0200,

Re: [PATCH 02/14] lmb: Use CONFIG_LMB_*_REGIONS only if they are defined

2021-09-04 Thread Tom Rini
[trimming the CC list] On Sat, Sep 04, 2021 at 06:49:03PM +0200, Marek Vasut wrote: > On 9/4/21 6:09 PM, Tom Rini wrote: > > On Sat, Sep 04, 2021 at 06:05:50PM +0200, Marek Vasut wrote: > > > On 9/4/21 5:17 PM, Tom Rini wrote: > > > > On Sat, Sep 04, 2021 at 05:15:45PM +0200, Marek Vasut wrote: >

Re: [PATCH 02/14] lmb: Use CONFIG_LMB_*_REGIONS only if they are defined

2021-09-04 Thread Marek Vasut
On 9/4/21 6:09 PM, Tom Rini wrote: On Sat, Sep 04, 2021 at 06:05:50PM +0200, Marek Vasut wrote: On 9/4/21 5:17 PM, Tom Rini wrote: On Sat, Sep 04, 2021 at 05:15:45PM +0200, Marek Vasut wrote: On 9/4/21 4:10 PM, Tom Rini wrote: [...] At this point, I think you should rework things to stop mak

Re: [PATCH 02/14] lmb: Use CONFIG_LMB_*_REGIONS only if they are defined

2021-09-04 Thread Tom Rini
On Sat, Sep 04, 2021 at 06:05:50PM +0200, Marek Vasut wrote: > On 9/4/21 5:17 PM, Tom Rini wrote: > > On Sat, Sep 04, 2021 at 05:15:45PM +0200, Marek Vasut wrote: > > > On 9/4/21 4:10 PM, Tom Rini wrote: > > > [...] > > > > > > > > > > > At this point, I think you should rework things to stop maki

Re: [PATCH 02/14] lmb: Use CONFIG_LMB_*_REGIONS only if they are defined

2021-09-04 Thread Marek Vasut
On 9/4/21 5:17 PM, Tom Rini wrote: On Sat, Sep 04, 2021 at 05:15:45PM +0200, Marek Vasut wrote: On 9/4/21 4:10 PM, Tom Rini wrote: [...] At this point, I think you should rework things to stop making CONFIG_LMB be optional, it should be a def_bool y. I disagree, see above. The only reason

Re: [PATCH 02/14] lmb: Use CONFIG_LMB_*_REGIONS only if they are defined

2021-09-04 Thread Tom Rini
On Sat, Sep 04, 2021 at 05:15:45PM +0200, Marek Vasut wrote: > On 9/4/21 4:10 PM, Tom Rini wrote: > [...] > > > > > > > At this point, I think you should rework things to stop making > > > > > > CONFIG_LMB be optional, it should be a def_bool y. > > > > > > > > > > I disagree, see above. > > > >

Re: [PATCH 02/14] lmb: Use CONFIG_LMB_*_REGIONS only if they are defined

2021-09-04 Thread Marek Vasut
On 9/4/21 4:10 PM, Tom Rini wrote: [...] At this point, I think you should rework things to stop making CONFIG_LMB be optional, it should be a def_bool y. I disagree, see above. The only reason "tools-only_defconfig" builds a useless u-boot binary today is in CI where it would be more work t

Re: [PATCH 02/14] lmb: Use CONFIG_LMB_*_REGIONS only if they are defined

2021-09-04 Thread Tom Rini
On Sat, Sep 04, 2021 at 04:03:25PM +0200, Marek Vasut wrote: > On 8/30/21 2:01 PM, Tom Rini wrote: > > [...] > > > > > > > > > > > > > > > > > We shouldn't need this at all. LMB and > > > > > > > > > > > > > > > > LMB_USE_MAX_REGIONS are both in > > > > > > > > > > > > > > > > Kconfig and have

Re: [PATCH 02/14] lmb: Use CONFIG_LMB_*_REGIONS only if they are defined

2021-09-04 Thread Marek Vasut
On 8/30/21 2:01 PM, Tom Rini wrote: [...] We shouldn't need this at all. LMB and LMB_USE_MAX_REGIONS are both in Kconfig and have the dependencies expressed that way. However, CONFIG_LMB_MEMORY_REGIONS and CONFIG_LMB_RESERVED_REGIONS may be undefined if CONFIG_LMB and !CONFIG_LMB_USE_MAX_REG

Re: [PATCH 02/14] lmb: Use CONFIG_LMB_*_REGIONS only if they are defined

2021-08-30 Thread Tom Rini
On Mon, Aug 30, 2021 at 11:45:02AM +0200, Marek Vasut wrote: > On 8/30/21 1:11 AM, Tom Rini wrote: > > On Mon, Aug 30, 2021 at 01:00:02AM +0200, Marek Vasut wrote: > > > On 8/30/21 12:51 AM, Tom Rini wrote: > > > > On Mon, Aug 30, 2021 at 12:40:07AM +0200, Marek Vasut wrote: > > > > > On 8/30/21 12

Re: [PATCH 02/14] lmb: Use CONFIG_LMB_*_REGIONS only if they are defined

2021-08-30 Thread Marek Vasut
On 8/30/21 1:11 AM, Tom Rini wrote: On Mon, Aug 30, 2021 at 01:00:02AM +0200, Marek Vasut wrote: On 8/30/21 12:51 AM, Tom Rini wrote: On Mon, Aug 30, 2021 at 12:40:07AM +0200, Marek Vasut wrote: On 8/30/21 12:23 AM, Tom Rini wrote: On Mon, Aug 30, 2021 at 12:19:59AM +0200, Marek Vasut wrote:

Re: [PATCH 02/14] lmb: Use CONFIG_LMB_*_REGIONS only if they are defined

2021-08-29 Thread Tom Rini
On Mon, Aug 30, 2021 at 01:00:02AM +0200, Marek Vasut wrote: > On 8/30/21 12:51 AM, Tom Rini wrote: > > On Mon, Aug 30, 2021 at 12:40:07AM +0200, Marek Vasut wrote: > > > On 8/30/21 12:23 AM, Tom Rini wrote: > > > > On Mon, Aug 30, 2021 at 12:19:59AM +0200, Marek Vasut wrote: > > > > > On 8/30/21 1

Re: [PATCH 02/14] lmb: Use CONFIG_LMB_*_REGIONS only if they are defined

2021-08-29 Thread Marek Vasut
On 8/30/21 12:51 AM, Tom Rini wrote: On Mon, Aug 30, 2021 at 12:40:07AM +0200, Marek Vasut wrote: On 8/30/21 12:23 AM, Tom Rini wrote: On Mon, Aug 30, 2021 at 12:19:59AM +0200, Marek Vasut wrote: On 8/30/21 12:10 AM, Tom Rini wrote: On Sun, Aug 29, 2021 at 11:47:58PM +0200, Marek Vasut wrote:

Re: [PATCH 02/14] lmb: Use CONFIG_LMB_*_REGIONS only if they are defined

2021-08-29 Thread Tom Rini
On Mon, Aug 30, 2021 at 12:40:07AM +0200, Marek Vasut wrote: > On 8/30/21 12:23 AM, Tom Rini wrote: > > On Mon, Aug 30, 2021 at 12:19:59AM +0200, Marek Vasut wrote: > > > On 8/30/21 12:10 AM, Tom Rini wrote: > > > > On Sun, Aug 29, 2021 at 11:47:58PM +0200, Marek Vasut wrote: > > > > > On 8/29/21 9

Re: [PATCH 02/14] lmb: Use CONFIG_LMB_*_REGIONS only if they are defined

2021-08-29 Thread Marek Vasut
On 8/30/21 12:23 AM, Tom Rini wrote: On Mon, Aug 30, 2021 at 12:19:59AM +0200, Marek Vasut wrote: On 8/30/21 12:10 AM, Tom Rini wrote: On Sun, Aug 29, 2021 at 11:47:58PM +0200, Marek Vasut wrote: On 8/29/21 9:32 PM, Tom Rini wrote: On Sun, Aug 29, 2021 at 09:24:46PM +0200, Marek Vasut wrote:

Re: [PATCH 02/14] lmb: Use CONFIG_LMB_*_REGIONS only if they are defined

2021-08-29 Thread Tom Rini
On Mon, Aug 30, 2021 at 12:19:59AM +0200, Marek Vasut wrote: > On 8/30/21 12:10 AM, Tom Rini wrote: > > On Sun, Aug 29, 2021 at 11:47:58PM +0200, Marek Vasut wrote: > > > On 8/29/21 9:32 PM, Tom Rini wrote: > > > > On Sun, Aug 29, 2021 at 09:24:46PM +0200, Marek Vasut wrote: > > > > > On 8/29/21 8:

Re: [PATCH 02/14] lmb: Use CONFIG_LMB_*_REGIONS only if they are defined

2021-08-29 Thread Marek Vasut
On 8/30/21 12:10 AM, Tom Rini wrote: On Sun, Aug 29, 2021 at 11:47:58PM +0200, Marek Vasut wrote: On 8/29/21 9:32 PM, Tom Rini wrote: On Sun, Aug 29, 2021 at 09:24:46PM +0200, Marek Vasut wrote: On 8/29/21 8:02 PM, Tom Rini wrote: On Sun, Aug 29, 2021 at 06:26:23PM +0200, Marek Vasut wrote:

Re: [PATCH 02/14] lmb: Use CONFIG_LMB_*_REGIONS only if they are defined

2021-08-29 Thread Tom Rini
On Sun, Aug 29, 2021 at 11:47:58PM +0200, Marek Vasut wrote: > On 8/29/21 9:32 PM, Tom Rini wrote: > > On Sun, Aug 29, 2021 at 09:24:46PM +0200, Marek Vasut wrote: > > > On 8/29/21 8:02 PM, Tom Rini wrote: > > > > On Sun, Aug 29, 2021 at 06:26:23PM +0200, Marek Vasut wrote: > > > > > On 8/15/21 9:4

Re: [PATCH 02/14] lmb: Use CONFIG_LMB_*_REGIONS only if they are defined

2021-08-29 Thread Marek Vasut
On 8/29/21 9:32 PM, Tom Rini wrote: On Sun, Aug 29, 2021 at 09:24:46PM +0200, Marek Vasut wrote: On 8/29/21 8:02 PM, Tom Rini wrote: On Sun, Aug 29, 2021 at 06:26:23PM +0200, Marek Vasut wrote: On 8/15/21 9:47 PM, Tom Rini wrote: On Sun, Aug 15, 2021 at 08:13:02PM +0200, Marek Vasut wrote:

Re: [PATCH 02/14] lmb: Use CONFIG_LMB_*_REGIONS only if they are defined

2021-08-29 Thread Tom Rini
On Sun, Aug 29, 2021 at 09:24:46PM +0200, Marek Vasut wrote: > On 8/29/21 8:02 PM, Tom Rini wrote: > > On Sun, Aug 29, 2021 at 06:26:23PM +0200, Marek Vasut wrote: > > > On 8/15/21 9:47 PM, Tom Rini wrote: > > > > On Sun, Aug 15, 2021 at 08:13:02PM +0200, Marek Vasut wrote: > > > > > > > > > The C

Re: [PATCH 02/14] lmb: Use CONFIG_LMB_*_REGIONS only if they are defined

2021-08-29 Thread Marek Vasut
On 8/29/21 8:02 PM, Tom Rini wrote: On Sun, Aug 29, 2021 at 06:26:23PM +0200, Marek Vasut wrote: On 8/15/21 9:47 PM, Tom Rini wrote: On Sun, Aug 15, 2021 at 08:13:02PM +0200, Marek Vasut wrote: The CONFIG_LMB_*_REGIONS are defined only if CONFIG_LMB is enabled, protect access to those two con

Re: [PATCH 02/14] lmb: Use CONFIG_LMB_*_REGIONS only if they are defined

2021-08-29 Thread Tom Rini
On Sun, Aug 29, 2021 at 06:26:23PM +0200, Marek Vasut wrote: > On 8/15/21 9:47 PM, Tom Rini wrote: > > On Sun, Aug 15, 2021 at 08:13:02PM +0200, Marek Vasut wrote: > > > > > The CONFIG_LMB_*_REGIONS are defined only if CONFIG_LMB is enabled, > > > protect access to those two config options to avoi

Re: [PATCH 02/14] lmb: Use CONFIG_LMB_*_REGIONS only if they are defined

2021-08-29 Thread Marek Vasut
On 8/15/21 9:47 PM, Tom Rini wrote: On Sun, Aug 15, 2021 at 08:13:02PM +0200, Marek Vasut wrote: The CONFIG_LMB_*_REGIONS are defined only if CONFIG_LMB is enabled, protect access to those two config options to avoid undefined macro errors. Signed-off-by: Marek Vasut Cc: Simon Glass Cc: Simo

Re: [PATCH 02/14] lmb: Use CONFIG_LMB_*_REGIONS only if they are defined

2021-08-15 Thread Tom Rini
On Sun, Aug 15, 2021 at 08:13:02PM +0200, Marek Vasut wrote: > The CONFIG_LMB_*_REGIONS are defined only if CONFIG_LMB is enabled, > protect access to those two config options to avoid undefined macro > errors. > > Signed-off-by: Marek Vasut > Cc: Simon Glass > Cc: Simon Goldschmidt > Cc: Tom

[PATCH 02/14] lmb: Use CONFIG_LMB_*_REGIONS only if they are defined

2021-08-15 Thread Marek Vasut
The CONFIG_LMB_*_REGIONS are defined only if CONFIG_LMB is enabled, protect access to those two config options to avoid undefined macro errors. Signed-off-by: Marek Vasut Cc: Simon Glass Cc: Simon Goldschmidt Cc: Tom Rini --- include/lmb.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletion