Re: [PATCH 01/13] arm: nanopi2: Remove unused code

On Sat, Apr 10, 2021 at 07:14:31PM +0200, Stefan Bosch wrote: > Hi Tom, > > CONFIG_REVISION_TAG has originally been defined in s5p4418_nanopi2.h. But > this gets lost sometime in the past. Below my proposal for a patch which > uses CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG instead. > > Regards > Stef

Re: [PATCH 01/13] arm: nanopi2: Remove unused code

Hi Tom, CONFIG_REVISION_TAG has originally been defined in s5p4418_nanopi2.h. But this gets lost sometime in the past. Below my proposal for a patch which uses CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG instead. Regards Stefan Signed-off-by: Stefan Bosch --- board/friendlyarm/nanopi2/board.c |

Re: [PATCH 01/13] arm: nanopi2: Remove unused code

Hi, thanks for the info, I'll have a look at this. Regards Stefan On 04.02.21 03:24, Tom Rini wrote: This platform did not ever enable CONFIG_REVISION_TAG, so the code to set the board_rev environment variable was never enabled. This particular symbol is also only for use with the REVISION AT

[PATCH 01/13] arm: nanopi2: Remove unused code

This platform did not ever enable CONFIG_REVISION_TAG, so the code to set the board_rev environment variable was never enabled. This particular symbol is also only for use with the REVISION ATAG and this platform is new enough to have never supported an ATAG-based Linux Kernel. Cc: Stefan Bosch