Re: [PATCH 00/13] efi: Tidy up confusion between pointers and addresses

2024-11-30 Thread Simon Glass
Hi Mark, On Wed, 27 Nov 2024 at 06:52, Mark Kettenis wrote: > > > From: Simon Glass > > Date: Wed, 27 Nov 2024 06:08:10 -0700 > > Hi Simon, > > > Hi Tom, > > > > On Tue, 26 Nov 2024 at 09:08, Tom Rini wrote: > > > > > > On Tue, Nov 26, 2024 at 08:39:05AM -0700, Simon Glass wrote: > > > > Hi Hei

Re: [PATCH 00/13] efi: Tidy up confusion between pointers and addresses

2024-11-27 Thread Mark Kettenis
> From: Simon Glass > Date: Wed, 27 Nov 2024 06:08:10 -0700 Hi Simon, > Hi Tom, > > On Tue, 26 Nov 2024 at 09:08, Tom Rini wrote: > > > > On Tue, Nov 26, 2024 at 08:39:05AM -0700, Simon Glass wrote: > > > Hi Heinrich, > > > > > > On Tue, 26 Nov 2024 at 02:10, Heinrich Schuchardt > > > wrote:

Re: [PATCH 00/13] efi: Tidy up confusion between pointers and addresses

2024-11-27 Thread Simon Glass
Hi Tom, On Tue, 26 Nov 2024 at 09:08, Tom Rini wrote: > > On Tue, Nov 26, 2024 at 08:39:05AM -0700, Simon Glass wrote: > > Hi Heinrich, > > > > On Tue, 26 Nov 2024 at 02:10, Heinrich Schuchardt > > wrote: > > > > > > On 25.11.24 21:44, Simon Glass wrote: > > > > The EFI-loader implementation co

Re: [PATCH 00/13] efi: Tidy up confusion between pointers and addresses

2024-11-26 Thread Tom Rini
On Tue, Nov 26, 2024 at 08:39:05AM -0700, Simon Glass wrote: > Hi Heinrich, > > On Tue, 26 Nov 2024 at 02:10, Heinrich Schuchardt wrote: > > > > On 25.11.24 21:44, Simon Glass wrote: > > > The EFI-loader implementation converts things back and forth between > > > addresses and pointers, with not

Re: [PATCH 00/13] efi: Tidy up confusion between pointers and addresses

2024-11-26 Thread Simon Glass
Hi Ilias, On Tue, 26 Nov 2024 at 01:13, Ilias Apalodimas wrote: > > Hi Simon > > Apart from the comments on the other patches, the SCT memory tests > crash with this series. Please run it locally before sending a v2. I did briefly get it running on my laptop, but not for x86_64. I understand fro

Re: [PATCH 00/13] efi: Tidy up confusion between pointers and addresses

2024-11-26 Thread Simon Glass
Hi Heinrich, On Tue, 26 Nov 2024 at 02:10, Heinrich Schuchardt wrote: > > On 25.11.24 21:44, Simon Glass wrote: > > The EFI-loader implementation converts things back and forth between > > addresses and pointers, with not much consistency in how this is done. > > > > Within most of U-Boot a point

Re: [PATCH 00/13] efi: Tidy up confusion between pointers and addresses

2024-11-26 Thread Heinrich Schuchardt
On 25.11.24 21:44, Simon Glass wrote: The EFI-loader implementation converts things back and forth between addresses and pointers, with not much consistency in how this is done. Within most of U-Boot a pointer is a void * and an address is a ulong No. It is phys_addr_t that was introduced to h

Re: [PATCH 00/13] efi: Tidy up confusion between pointers and addresses

2024-11-26 Thread Ilias Apalodimas
Hi Simon Apart from the comments on the other patches, the SCT memory tests crash with this series. Please run it locally before sending a v2. Thanks /Ilias On Mon, 25 Nov 2024 at 22:45, Simon Glass wrote: > > The EFI-loader implementation converts things back and forth between > addresses and

[PATCH 00/13] efi: Tidy up confusion between pointers and addresses

2024-11-25 Thread Simon Glass
The EFI-loader implementation converts things back and forth between addresses and pointers, with not much consistency in how this is done. Within most of U-Boot a pointer is a void * and an address is a ulong This convention is very helpful, since it is obvious in common code as to whether you n