Re: [PATCH] tools: fix handle leak in ifdtool.c

2025-05-19 Thread Anton Moryakov
Maybe. However, the static analyser did not swear at others Пн, 19 мая 2025 г. в 11:47, Quentin Schulz : > Hi Anton, > > On 5/16/25 5:25 PM, ant.v.morya...@gmail.com wrote: > > From: Anton Moryakov > > > > Prevent file descriptor leaks by properly closing 'fd' and 'new_fd' > > when fstat() or w

Re: [PATCH] tools: fix handle leak in ifdtool.c

2025-05-19 Thread Quentin Schulz
Hi Anton, On 5/16/25 5:25 PM, ant.v.morya...@gmail.com wrote: From: Anton Moryakov Prevent file descriptor leaks by properly closing 'fd' and 'new_fd' when fstat() or write() operations fail. - Added close(fd) before return in open_for_read() if fstat() fails. - Added close(new_fd) before ret

[PATCH] tools: fix handle leak in ifdtool.c

2025-05-16 Thread ant . v . moryakov
From: Anton Moryakov Prevent file descriptor leaks by properly closing 'fd' and 'new_fd' when fstat() or write() operations fail. - Added close(fd) before return in open_for_read() if fstat() fails. - Added close(new_fd) before return in write_image() if write() fails. - No close needed if open(