Re: [PATCH] tcpm: fix pd_transmit poll condition

2025-06-26 Thread Sebastian Reichel
Hi, On Mon, May 26, 2025 at 09:42:53AM +0200, Neil Armstrong wrote: > The read_poll_timeout() exit "cond" parameter wait for a complete > transmit state. > > The "!tx_complete" cond means that on the first tcpm_transmit_helper() > call, if the tx_complete returns to false, the poll loop would exi

Re: [PATCH] tcpm: fix pd_transmit poll condition

2025-06-18 Thread Marcel Ziswiler
Hi Neil Good catch. Thanks! On Mon, 2025-05-26 at 09:42 +0200, Neil Armstrong wrote: > The read_poll_timeout() exit "cond" parameter wait for a complete > transmit state. > > The "!tx_complete" cond means that on the first tcpm_transmit_helper() > call, if the tx_complete returns to false, the p

[PATCH] tcpm: fix pd_transmit poll condition

2025-05-26 Thread Neil Armstrong
The read_poll_timeout() exit "cond" parameter wait for a complete transmit state. The "!tx_complete" cond means that on the first tcpm_transmit_helper() call, if the tx_complete returns to false, the poll loop would exit. But since at probe the tx_status is left at 0, the tx is considered as succe