Re: [PATCH] smcc: fix sign bit expansion

2021-01-20 Thread Jens Wiklander
On Tue, Jan 05, 2021 at 08:03:11PM +, Volodymyr Babchuk wrote: > Signed ARM_SMCCC_FAST_CALL value is shifted to 31'st bit. Then, it is expanded > to 64 bit value, which results in 1s in higher 32 bits. > > This causes corrupted values in 64-bit SMC IDs and issues in buggy handlers of > 32-bit

[PATCH] smcc: fix sign bit expansion

2021-01-06 Thread Volodymyr Babchuk
Signed ARM_SMCCC_FAST_CALL value is shifted to 31'st bit. Then, it is expanded to 64 bit value, which results in 1s in higher 32 bits. This causes corrupted values in 64-bit SMC IDs and issues in buggy handlers of 32-bit calls. We need to make ARM_SMCCC_FAST_CALL unsigned long, so it would work p