Re: [PATCH] rockchip: rk3568: add support of all UART

2024-01-08 Thread Arseniy Mescheryakov
Hello, you are right, that this patch is not needed for working console and with property configured dt and config it works. But for debug (for example, everything that was printed by debug()) it is needed. Withit this code you will not see this prints. And yes, via DDR blob you can configure a spe

Re: [PATCH] rockchip: rk3568: add support of all UART

2024-01-01 Thread Kever Yang
Hi Arseniy, On 2024/1/1 21:43, Arseniy Mescheryakov wrote: Thanks for the answer. I think developers should have the opportunity to configure UART from the u-boot directly (via configuration) without any additional proprietary blobs. The soc driver source code is used for hardware, I think soc v

Re: [PATCH] rockchip: rk3568: add support of all UART

2024-01-01 Thread Jonas Karlman
Hi Arseniy, On 2024-01-01 14:43, Arseniy Mescheryakov wrote: > Thanks for the answer. > I think developers should have the opportunity to configure UART from > the u-boot directly (via configuration) without any additional > proprietary blobs. Sure and it should already be possible using existing

Re: [PATCH] rockchip: rk3568: add support of all UART

2024-01-01 Thread Arseniy Mescheryakov
Thanks for the answer. I think developers should have the opportunity to configure UART from the u-boot directly (via configuration) without any additional proprietary blobs. There is https://github.com/rockchip-linux/u-boot/blob/next-dev/arch/arm/mach-rockchip/rk3568/rk3568.c , that has same fun

Re: [PATCH] rockchip: rk3568: add support of all UART

2023-12-30 Thread Jonas Karlman
Hi Arseniy, On 2023-12-30 12:20, Arseniy Meshcheryakov wrote: > This patch add support of all UARTs for rk3568, which can be used in console. Please explain why this is needed, on rk35xx the rockchip ddr init blob is required and can setup correct uart iomux with rkbin/tools/ddrbin_tool [1]. And

[PATCH] rockchip: rk3568: add support of all UART

2023-12-30 Thread Arseniy Meshcheryakov
This patch add support of all UARTs for rk3568, which can be used in console. Signed-off-by: Arseniy Meshcheryakov --- arch/arm/mach-rockchip/rk3568/rk3568.c | 470 - 1 file changed, 452 insertions(+), 18 deletions(-) diff --git a/arch/arm/mach-rockchip/rk3568/rk3568.c