Re: [PATCH] riscv: Try to get cpu frequency from device tree

2020-02-04 Thread Sean Anderson
On 2/4/20 9:27 AM, Bin Meng wrote: > Hi Sean, > > On Tue, Feb 4, 2020 at 10:06 PM Sean Anderson wrote: >> >> On 2/4/20 5:36 AM, Bin Meng wrote: >>> On Mon, Feb 3, 2020 at 1:40 AM Sean Anderson wrote: >>> I believe both 2 patches in this series are needed by "riscv: Add >>> Sipeed Maix support" s

Re: [PATCH] riscv: Try to get cpu frequency from device tree

2020-02-04 Thread Bin Meng
Hi Sean, On Tue, Feb 4, 2020 at 10:06 PM Sean Anderson wrote: > > On 2/4/20 5:36 AM, Bin Meng wrote: > > On Mon, Feb 3, 2020 at 1:40 AM Sean Anderson wrote: > > I believe both 2 patches in this series are needed by "riscv: Add > > Sipeed Maix support" series? > > If yes, I think you can just put

Re: [PATCH] riscv: Try to get cpu frequency from device tree

2020-02-04 Thread Sean Anderson
On 2/4/20 5:36 AM, Bin Meng wrote: > On Mon, Feb 3, 2020 at 1:40 AM Sean Anderson wrote: > I believe both 2 patches in this series are needed by "riscv: Add > Sipeed Maix support" series? > If yes, I think you can just put 2 patches into the same series, to > give people a good context next time.

Re: [PATCH] riscv: Try to get cpu frequency from device tree

2020-01-30 Thread Rick Chen
Hi Sean > From: U-Boot [mailto:u-boot-boun...@lists.denx.de] On Behalf Of Lukas Auer > Sent: Monday, January 27, 2020 6:26 AM > To: u-boot@lists.denx.de; sean...@gmail.com > Subject: Re: [PATCH] riscv: Try to get cpu frequency from device tree > > On Sun, 2020-01-26 at 13:20 -0

Re: [PATCH] riscv: Try to get cpu frequency from device tree

2020-01-26 Thread Lukas Auer
On Sun, 2020-01-26 at 13:20 -0500, Sean Anderson wrote: > On 1/26/20 11:34 AM, Lukas Auer wrote: > > Hi Sean, > > Usually, ret is used as a variable name here. I think it would actually > > make the code a bit nicer to read here, because the clock rate is not > > read from variable err. > > Hm, I

Re: [PATCH] riscv: Try to get cpu frequency from device tree

2020-01-26 Thread Sean Anderson
On 1/26/20 11:34 AM, Lukas Auer wrote: > Hi Sean, > Usually, ret is used as a variable name here. I think it would actually > make the code a bit nicer to read here, because the clock rate is not > read from variable err. Hm, I chose err instead of ret since that variable is never the return value

Re: [PATCH] riscv: Try to get cpu frequency from device tree

2020-01-26 Thread Lukas Auer
Hi Sean, On Fri, 2020-01-17 at 14:51 -0500, Sean Anderson wrote: > Instead of always using the "clock-frequency" property to determine cpu > frequency, try using a clock in "clocks" if it exists. > > Signed-off-by Sean Anderson > --- > This patch depends on

[PATCH] riscv: Try to get cpu frequency from device tree

2020-01-17 Thread Sean Anderson
Instead of always using the "clock-frequency" property to determine cpu frequency, try using a clock in "clocks" if it exists. Signed-off-by Sean Anderson --- This patch depends on . drivers/cpu/riscv_cpu.c | 16 +++- 1 file changed, 15 i