Re: [PATCH] riscv: Fix arch_fixup_fdt always failing without /chosen

2021-05-14 Thread Atish Patra
On Sat, May 8, 2021 at 9:13 AM Sean Anderson wrote: > > If /chosen was missing, chosen_offset would never get updated with the new > /chosen node. This would cause fdt_setprop_u32 to fail. This patch fixes > this by setting chosen_offset. In addition, log any errors from setting > boot-hartid as w

Re: [PATCH] riscv: Fix arch_fixup_fdt always failing without /chosen

2021-05-13 Thread Bin Meng
Hi Sean, On Sun, May 9, 2021 at 12:24 AM Sean Anderson wrote: > > On 5/8/21 12:22 PM, Bin Meng wrote: > > On Sun, May 9, 2021 at 12:13 AM Sean Anderson wrote: > >> > >> If /chosen was missing, chosen_offset would never get updated with the new > >> /chosen node. This would cause fdt_setprop_u32

Re: [PATCH] riscv: Fix arch_fixup_fdt always failing without /chosen

2021-05-09 Thread Rick Chen
> If /chosen was missing, chosen_offset would never get updated with the new > /chosen node. This would cause fdt_setprop_u32 to fail. This patch fixes > this by setting chosen_offset. In addition, log any errors from setting > boot-hartid as well. > > Fixes: 177c53fe6c6 ("riscv: Move all fdt fixup

Re: [PATCH] riscv: Fix arch_fixup_fdt always failing without /chosen

2021-05-08 Thread Sean Anderson
On 5/8/21 12:22 PM, Bin Meng wrote: On Sun, May 9, 2021 at 12:13 AM Sean Anderson wrote: If /chosen was missing, chosen_offset would never get updated with the new /chosen node. This would cause fdt_setprop_u32 to fail. This patch fixes this by setting chosen_offset. In addition, log any error

Re: [PATCH] riscv: Fix arch_fixup_fdt always failing without /chosen

2021-05-08 Thread Bin Meng
On Sun, May 9, 2021 at 12:13 AM Sean Anderson wrote: > > If /chosen was missing, chosen_offset would never get updated with the new > /chosen node. This would cause fdt_setprop_u32 to fail. This patch fixes > this by setting chosen_offset. In addition, log any errors from setting > boot-hartid as

[PATCH] riscv: Fix arch_fixup_fdt always failing without /chosen

2021-05-08 Thread Sean Anderson
If /chosen was missing, chosen_offset would never get updated with the new /chosen node. This would cause fdt_setprop_u32 to fail. This patch fixes this by setting chosen_offset. In addition, log any errors from setting boot-hartid as well. Fixes: 177c53fe6c6 ("riscv: Move all fdt fixups together"