Re: [PATCH] nvme: fix for big endian systems

2021-06-23 Thread Bin Meng
On Sat, Jun 19, 2021 at 10:15 PM Bin Meng wrote: > > On Sat, May 8, 2021 at 12:49 AM David Lamparter wrote: > > > > writel() and co. already include the endian swap; doing the swap twice > > is, er, unhelpful. > > > > Tested on a P4080DS, which boots perfectly fine off NVMe with this. > > > > Si

Re: [PATCH] nvme: fix for big endian systems

2021-06-19 Thread Bin Meng
On Sat, Jun 19, 2021 at 10:10 PM David Lamparter wrote: > > On Tue, May 18, 2021 at 01:09:17PM +0200, David Lamparter wrote: > > On Thu, May 06, 2021 at 08:24:30PM +0200, David Lamparter wrote: > > > writel() and co. already include the endian swap; doing the swap twice > > > is, er, unhelpful. >

Re: [PATCH] nvme: fix for big endian systems

2021-06-19 Thread Bin Meng
On Sat, May 8, 2021 at 12:49 AM David Lamparter wrote: > > writel() and co. already include the endian swap; doing the swap twice > is, er, unhelpful. > > Tested on a P4080DS, which boots perfectly fine off NVMe with this. > > Signed-off-by: David Lamparter > --- > drivers/nvme/nvme.c | 8 -

Re: [PATCH] nvme: fix for big endian systems

2021-06-19 Thread David Lamparter
On Tue, May 18, 2021 at 01:09:17PM +0200, David Lamparter wrote: > On Thu, May 06, 2021 at 08:24:30PM +0200, David Lamparter wrote: > > writel() and co. already include the endian swap; doing the swap twice > > is, er, unhelpful. > > > > Tested on a P4080DS, which boots perfectly fine off NVMe wi

Re: [PATCH] nvme: fix for big endian systems

2021-05-18 Thread David Lamparter
Hi all, On Thu, May 06, 2021 at 08:24:30PM +0200, David Lamparter wrote: > writel() and co. already include the endian swap; doing the swap twice > is, er, unhelpful. > > Tested on a P4080DS, which boots perfectly fine off NVMe with this. is there anything to be done on my end to get this merg

[PATCH] nvme: fix for big endian systems

2021-05-07 Thread David Lamparter
writel() and co. already include the endian swap; doing the swap twice is, er, unhelpful. Tested on a P4080DS, which boots perfectly fine off NVMe with this. Signed-off-by: David Lamparter --- drivers/nvme/nvme.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drive